You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Nicolas Peltier <np...@adobe.com> on 2015/10/12 15:49:05 UTC
[VOTE] accept the donation of sling pipes tracked in SLING-5134
Hi,
this thread is about voting for the acceptation of sling pipes donation, tracked in SLING-5134.
An archive containing the contribution is attached to SLING-5134, shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on github at [0]
Please cast your votes.
Cheers,
Nicolas
[0] https://github.com/npeltier/sling-pipes
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
thx for the tip!
> On 23 Oct 2015, at 15:13, Sandro Boehme <sa...@gmx.de> wrote:
>
> Hi Nicolas,
>
> I've configured my email client to display conversations as a thread as long as people "answer" to an email and I can imagine that it's the same for other people as well. To stop this vote thread as Carsten suggested it would be better to write a new email with a new subject to dev@sling.apache.org. This way your email would be more prominent in the mailing list and people would recognize your donation offer.
> You will have my +1 in any case!
>
> Best,
>
> Sandro
>
> Am 23.10.15 um 13:56 schrieb Nicolas Peltier:
>> bump
>>> On 17 Oct 2015, at 10:54, Nicolas Peltier <np...@adobe.com> wrote:
>>>
>>> Hi,
>>>
>>> fixed the test issue for both java version (i should say nashorn versions) thanks to Robert’s patch.
>>> new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, please vote
>>>
>>> Nicolas
>>>
>>>> On 15 Oct 2015, at 14:42, Nicolas Peltier <np...@adobe.com> wrote:
>>>>
>>>> yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that.
>>>>
>>>> Nicolas
>>>>> On 15 Oct 2015, at 14:34, Carsten Ziegeler <cz...@apache.org> wrote:
>>>>>
>>>>> Can we maybe stop this vote thread, resolve the issues and then start a
>>>>> clean vote thread? Otherwise tracking this is very hard.
>>>>>
>>>>> Thanks
>>>>> Carsten
>>>>> --
>>>>> Carsten Ziegeler
>>>>> Adobe Research Switzerland
>>>>> cziegeler@apache.org
>>>>
>>>
>>
>
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Sandro Boehme <sa...@gmx.de>.
Hi Nicolas,
I've configured my email client to display conversations as a thread as
long as people "answer" to an email and I can imagine that it's the same
for other people as well. To stop this vote thread as Carsten suggested
it would be better to write a new email with a new subject to
dev@sling.apache.org. This way your email would be more prominent in the
mailing list and people would recognize your donation offer.
You will have my +1 in any case!
Best,
Sandro
Am 23.10.15 um 13:56 schrieb Nicolas Peltier:
> bump
>> On 17 Oct 2015, at 10:54, Nicolas Peltier <np...@adobe.com> wrote:
>>
>> Hi,
>>
>> fixed the test issue for both java version (i should say nashorn versions) thanks to Robert’s patch.
>> new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, please vote
>>
>> Nicolas
>>
>>> On 15 Oct 2015, at 14:42, Nicolas Peltier <np...@adobe.com> wrote:
>>>
>>> yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that.
>>>
>>> Nicolas
>>>> On 15 Oct 2015, at 14:34, Carsten Ziegeler <cz...@apache.org> wrote:
>>>>
>>>> Can we maybe stop this vote thread, resolve the issues and then start a
>>>> clean vote thread? Otherwise tracking this is very hard.
>>>>
>>>> Thanks
>>>> Carsten
>>>> --
>>>> Carsten Ziegeler
>>>> Adobe Research Switzerland
>>>> cziegeler@apache.org
>>>
>>
>
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
bump
> On 17 Oct 2015, at 10:54, Nicolas Peltier <np...@adobe.com> wrote:
>
> Hi,
>
> fixed the test issue for both java version (i should say nashorn versions) thanks to Robert’s patch.
> new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, please vote
>
> Nicolas
>
>> On 15 Oct 2015, at 14:42, Nicolas Peltier <np...@adobe.com> wrote:
>>
>> yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that.
>>
>> Nicolas
>>> On 15 Oct 2015, at 14:34, Carsten Ziegeler <cz...@apache.org> wrote:
>>>
>>> Can we maybe stop this vote thread, resolve the issues and then start a
>>> clean vote thread? Otherwise tracking this is very hard.
>>>
>>> Thanks
>>> Carsten
>>> --
>>> Carsten Ziegeler
>>> Adobe Research Switzerland
>>> cziegeler@apache.org
>>
>
[VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
Hi,
fixed the test issue for both java version (i should say nashorn versions) thanks to Robert’s patch.
new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, please vote
Nicolas
> On 15 Oct 2015, at 14:42, Nicolas Peltier <np...@adobe.com> wrote:
>
> yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that.
>
> Nicolas
>> On 15 Oct 2015, at 14:34, Carsten Ziegeler <cz...@apache.org> wrote:
>>
>> Can we maybe stop this vote thread, resolve the issues and then start a
>> clean vote thread? Otherwise tracking this is very hard.
>>
>> Thanks
>> Carsten
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziegeler@apache.org
>
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
yes, closing this thread now, will resend a vote once it’s fixed. Sorry about that.
Nicolas
> On 15 Oct 2015, at 14:34, Carsten Ziegeler <cz...@apache.org> wrote:
>
> Can we maybe stop this vote thread, resolve the issues and then start a
> clean vote thread? Otherwise tracking this is very hard.
>
> Thanks
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Carsten Ziegeler <cz...@apache.org>.
Can we maybe stop this vote thread, resolve the issues and then start a
clean vote thread? Otherwise tracking this is very hard.
Thanks
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Robert Munteanu <ro...@apache.org>.
On Thu, 2015-10-15 at 12:24 +0000, Nicolas Peltier wrote:
> :-D (<- me getting nuts)
>
> wild guess is you run java 1.8_0.31, and your computer is at risk ;-
> ), please update to 1.8_0.60
How about the following 'fix'?
diff --git a/src/test/java/org/apache/sling/pipes/PipeBindingsTest.java
b/src/test/java/org/apache/sling/pipes/PipeBindingsTest.java
index 049af9b..ffb9291 100644
--- a/src/test/java/org/apache/sling/pipes/PipeBindingsTest.java
+++ b/src/test/java/org/apache/sling/pipes/PipeBindingsTest.java
@@ -97,7 +97,9 @@ public class PipeBindingsTest extends
AbstractPipeTest {
context.load().binaryFile("/testSum.js",
"/content/test/testSum.js");
Resource resource =
context.resourceResolver().getResource(PATH_PIPE + "/" +
NN_MOREBINDINGS);
PipeBindings bindings = new PipeBindings(resource);
- Object expression =
bindings.instantiateObject("${testSumFunction(1,2)}");
- assertEquals("computed expression have testSum script's
functionavailable", 3L, expression);
+ Number expression = (Number)
bindings.instantiateObject("${testSumFunction(1,2)}");
+
+
+ assertEquals("computed expression have testSum script's
functionavailable", 3, expression.intValue());
}
}
Robert
> > On 15 Oct 2015, at 13:58, Bertrand Delacretaz
> > <bd...@apache.org> wrote:
> >
> > Hi,
> >
> > On Thu, Oct 15, 2015 at 1:36 PM, Nicolas Peltier <npeltier@adobe.co
> > m> wrote:
> > > ... re-updated tarball & shasum with Robert’s issue fix....
> >
> > I'm still getting the following error running mvn clean install
> > with
> > java 1.8 on the archive with sha1
> > 68eee1fa87784ea841c80e88b344ec92deb0f848 :
> >
> > Failed tests:
> > PipeBindingsTest.testAdditionalScript:101 computed expression have
> > testSum script's functionavailable expected: java.lang.Long<3> but
> > was: java.lang.Integer<3>
> >
> > -Bertrand
>
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
:-D (<- me getting nuts)
wild guess is you run java 1.8_0.31, and your computer is at risk ;-), please update to 1.8_0.60
> On 15 Oct 2015, at 13:58, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> Hi,
>
> On Thu, Oct 15, 2015 at 1:36 PM, Nicolas Peltier <np...@adobe.com> wrote:
>> ... re-updated tarball & shasum with Robert’s issue fix....
>
> I'm still getting the following error running mvn clean install with
> java 1.8 on the archive with sha1
> 68eee1fa87784ea841c80e88b344ec92deb0f848 :
>
> Failed tests:
> PipeBindingsTest.testAdditionalScript:101 computed expression have
> testSum script's functionavailable expected: java.lang.Long<3> but
> was: java.lang.Integer<3>
>
> -Bertrand
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Thu, Oct 15, 2015 at 1:36 PM, Nicolas Peltier <np...@adobe.com> wrote:
>... re-updated tarball & shasum with Robert’s issue fix....
I'm still getting the following error running mvn clean install with
java 1.8 on the archive with sha1
68eee1fa87784ea841c80e88b344ec92deb0f848 :
Failed tests:
PipeBindingsTest.testAdditionalScript:101 computed expression have
testSum script's functionavailable expected: java.lang.Long<3> but
was: java.lang.Integer<3>
-Bertrand
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
re-updated tarball & shasum with Robert’s issue fix.
Please vote now :-)
Nicolas
> On 14 Oct 2015, at 21:26, Nicolas Peltier <np...@adobe.com> wrote:
>
> updated tarball & shasum, with additional bugfix.
>
> for your test issue, which version of java are you running?
>
>> On 14 Oct 2015, at 18:01, Nicolas Peltier <np...@adobe.com> wrote:
>>
>> Thanks Robert, will fix that and update the ticket then :-)
>>
>> Nicolas
>>> On 14 Oct 2015, at 17:23, Robert Munteanu <ro...@apache.org> wrote:
>>>
>>> On Wed, 2015-10-14 at 15:17 +0000, Nicolas Peltier wrote:
>>>> out of curiosity, can you tell me which one of the tests failed? (it
>>>> doesn’t on mine)
>>> testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time
>>> elapsed: 0.085 sec <<< FAILURE!
>>>
>>> java.lang.AssertionError: computed expression have testSum script's
>>> functionavailable expected: java.lang.Integer<3> but was:
>>> java.lang.Long<3>
>>> at org.junit.Assert.fail(Assert.java:88)
>>> at org.junit.Assert.failNotEquals(Assert.java:743)
>>> at org.junit.Assert.assertEquals(Assert.java:118)
>>> at
>>> org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin
>>> gsTest.java:101)
>>>
>>> BTW, the build previously passed due to my having configured additional
>>> Maven repositories, but does not build with default maven
>>> configurations as it contains references to unavailable artifacts:
>>>
>>> [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could
>>> not resolve dependencies for project
>>> org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure
>>> to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in
>>> https://repo.maven.apache.org/maven2 was cached in the local
>>> repository, resolution will not be reattempted until the update
>>> interval of central has elapsed or updates are forced -> [Help 1]
>>>
>>> I therefore withdraw my vote and suggest that you re-attach an archive
>>> with the proper dependencies and restart the test.
>>>
>>> Thanks,
>>>
>>> Robert
>>
>
Re: Sling pipes failing test (Was: [VOTE] accept the donation of
sling pipes tracked in SLING-5134)
Posted by Nicolas Peltier <np...@adobe.com>.
Thanks Robert, fixed it, and updated the ticket / will update the vote thread.
interesting case: 1.8.0_31’s nashorn returns 3(Integer) for 1+2 when 1.8.0_60 one returns 3L
this said it should just be a pain for the tests, as client code is generally agnostic of the type.
> On 15 Oct 2015, at 08:32, Robert Munteanu <ro...@apache.org> wrote:
>
> On Wed, 2015-10-14 at 19:26 +0000, Nicolas Peltier wrote:
>> for your test issue, which version of java are you running?
>
> $ mvn -v
> Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-
> 22T14:57:37+03:00)
> Maven home: /usr/share/java/maven
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.2.1-1-desktop", arch: "amd64", family:
> "unix"
>
> Robert
>
Sling pipes failing test (Was: [VOTE] accept the donation of sling
pipes tracked in SLING-5134)
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2015-10-14 at 19:26 +0000, Nicolas Peltier wrote:
> for your test issue, which version of java are you running?
$ mvn -v
Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-
22T14:57:37+03:00)
Maven home: /usr/share/java/maven
Java version: 1.8.0_60, vendor: Oracle Corporation
Java home: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.2.1-1-desktop", arch: "amd64", family:
"unix"
Robert
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
updated tarball & shasum, with additional bugfix.
for your test issue, which version of java are you running?
> On 14 Oct 2015, at 18:01, Nicolas Peltier <np...@adobe.com> wrote:
>
> Thanks Robert, will fix that and update the ticket then :-)
>
> Nicolas
>> On 14 Oct 2015, at 17:23, Robert Munteanu <ro...@apache.org> wrote:
>>
>> On Wed, 2015-10-14 at 15:17 +0000, Nicolas Peltier wrote:
>>> out of curiosity, can you tell me which one of the tests failed? (it
>>> doesn’t on mine)
>> testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time
>> elapsed: 0.085 sec <<< FAILURE!
>>
>> java.lang.AssertionError: computed expression have testSum script's
>> functionavailable expected: java.lang.Integer<3> but was:
>> java.lang.Long<3>
>> at org.junit.Assert.fail(Assert.java:88)
>> at org.junit.Assert.failNotEquals(Assert.java:743)
>> at org.junit.Assert.assertEquals(Assert.java:118)
>> at
>> org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin
>> gsTest.java:101)
>>
>> BTW, the build previously passed due to my having configured additional
>> Maven repositories, but does not build with default maven
>> configurations as it contains references to unavailable artifacts:
>>
>> [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could
>> not resolve dependencies for project
>> org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure
>> to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in
>> https://repo.maven.apache.org/maven2 was cached in the local
>> repository, resolution will not be reattempted until the update
>> interval of central has elapsed or updates are forced -> [Help 1]
>>
>> I therefore withdraw my vote and suggest that you re-attach an archive
>> with the proper dependencies and restart the test.
>>
>> Thanks,
>>
>> Robert
>
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
Thanks Robert, will fix that and update the ticket then :-)
Nicolas
> On 14 Oct 2015, at 17:23, Robert Munteanu <ro...@apache.org> wrote:
>
> On Wed, 2015-10-14 at 15:17 +0000, Nicolas Peltier wrote:
>> out of curiosity, can you tell me which one of the tests failed? (it
>> doesn’t on mine)
> testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time
> elapsed: 0.085 sec <<< FAILURE!
>
> java.lang.AssertionError: computed expression have testSum script's
> functionavailable expected: java.lang.Integer<3> but was:
> java.lang.Long<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at
> org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin
> gsTest.java:101)
>
> BTW, the build previously passed due to my having configured additional
> Maven repositories, but does not build with default maven
> configurations as it contains references to unavailable artifacts:
>
> [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could
> not resolve dependencies for project
> org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure
> to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in
> https://repo.maven.apache.org/maven2 was cached in the local
> repository, resolution will not be reattempted until the update
> interval of central has elapsed or updates are forced -> [Help 1]
>
> I therefore withdraw my vote and suggest that you re-attach an archive
> with the proper dependencies and restart the test.
>
> Thanks,
>
> Robert
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2015-10-14 at 15:17 +0000, Nicolas Peltier wrote:
> out of curiosity, can you tell me which one of the tests failed? (it
> doesn’t on mine)
testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time
elapsed: 0.085 sec <<< FAILURE!
java.lang.AssertionError: computed expression have testSum script's
functionavailable expected: java.lang.Integer<3> but was:
java.lang.Long<3>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at
org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin
gsTest.java:101)
BTW, the build previously passed due to my having configured additional
Maven repositories, but does not build with default maven
configurations as it contains references to unavailable artifacts:
[ERROR] Failed to execute goal on project org.apache.sling.pipes: Could
not resolve dependencies for project
org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure
to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in
https://repo.maven.apache.org/maven2 was cached in the local
repository, resolution will not be reattempted until the update
interval of central has elapsed or updates are forced -> [Help 1]
I therefore withdraw my vote and suggest that you re-attach an archive
with the proper dependencies and restart the test.
Thanks,
Robert
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Nicolas Peltier <np...@adobe.com>.
out of curiosity, can you tell me which one of the tests failed? (it doesn’t on mine)
Nicolas
> On 14 Oct 2015, at 14:57, Robert Munteanu <ro...@apache.org> wrote:
>
> On Mon, 2015-10-12 at 13:49 +0000, Nicolas Peltier wrote:
>> Hi,
>>
>> this thread is about voting for the acceptation of sling pipes
>> donation, tracked in SLING-5134.
>>
>> An archive containing the contribution is attached to SLING-5134,
>> shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on
>> github at [0]
>>
>> Please cast your votes.
>
> +1 .
>
> Downloaded the zip, verified that checksums match.
>
> Rat checks are OK, build passes (with -DskipTests due to one test
> failure, but that should not block the donation IMO).
>
> Robert
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2015-10-12 at 13:49 +0000, Nicolas Peltier wrote:
> Hi,
>
> this thread is about voting for the acceptation of sling pipes
> donation, tracked in SLING-5134.
>
> An archive containing the contribution is attached to SLING-5134,
> shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on
> github at [0]
>
> Please cast your votes.
+1 .
Downloaded the zip, verified that checksums match.
Rat checks are OK, build passes (with -DskipTests due to one test
failure, but that should not block the donation IMO).
Robert