[GitHub] [druid] FrankChen021 commented on pull request #10383: Fix ingestion failure of pretty-formatted JSON message

[GitBox <gi...@apache.org>]

FrankChen021 commented on pull request #10383:
URL: https://github.com/apache/druid/pull/10383#issuecomment-711954685


   The branch has been rebased on master because there're some conflicts with it.
   
   @jihoonson  Here're some explanation on the latest changes
   
   1st, a new method `InputRowListPlusRawValues`.`ofList` is added to create instance of that class by passing list of raw column and rows, while the old `of` methods are still kept mainly for no changes on old code;
   
   2nd `InputRowListPlusRawValues`.`getRawValues` is still kept without involving lots of changes on test cases;
   
   3rd, there's no changes made on existing `SamplerResponse` interface. All data returned are still row by row. I think keeping this interface contract is reasonable, because its inner container `SamplerResponseRow` is already a pair of `rawColumn` and parsed json map.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org