You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alexandrusoare (via GitHub)" <gi...@apache.org> on 2026/05/08 08:42:09 UTC
[PR] fix(mcp): raise right error [superset]
alexandrusoare opened a new pull request, #39964:
URL: https://github.com/apache/superset/pull/39964
### SUMMARY
**Problem:**
When a database is unreachable, MCP's `generate_chart` tool tells the user "Chart query failed to execute. The chart configuration is invalid" with suggestions like "Check that all columns exist." Users see this and think their chart config is wrong — when the real problem is the database is down.
**Root cause:**
`_compile_chart()` in `compile.py` already classifies database errors correctly and returns a structured `error_obj` with the right error type and message. But `generate_chart.py` was ignoring `error_obj` entirely — it threw it away and constructed a new hardcoded error with `error_type="compile_error"` and generic suggestions every time, regardless of what actually failed.
**Solution:**
Use `compile_result.error_obj` when available instead of hardcoding a new error. Fall back to the generic compile error only if `error_obj` is None. Also added `_classify_as_database_error()` in `compile.py` which uses Superset's existing `db_engine_spec.extract_errors()` to detect database errors — the same classification the UI uses.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39964:
URL: https://github.com/apache/superset/pull/39964#discussion_r3207521441
##########
superset/mcp_service/chart/compile.py:
##########
@@ -46,6 +49,21 @@
logger = logging.getLogger(__name__)
+_CONNECTION_ERROR_TYPES = {
+ SupersetErrorType.CONNECTION_INVALID_USERNAME_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PASSWORD_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR,
+ SupersetErrorType.CONNECTION_PORT_CLOSED_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PORT_ERROR,
+ SupersetErrorType.CONNECTION_HOST_DOWN_ERROR,
+ SupersetErrorType.CONNECTION_ACCESS_DENIED_ERROR,
+ SupersetErrorType.CONNECTION_UNKNOWN_DATABASE_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_PERMISSIONS_ERROR,
+ SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_TIMEOUT,
+ SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
Review Comment:
**Suggestion:** Including `GENERIC_DB_ENGINE_ERROR` in the connection-only allowlist causes `_classify_as_database_error()` to mark almost any compile failure as a database connectivity issue, because `db_engine_spec.extract_errors()` falls back to `GENERIC_DB_ENGINE_ERROR` for non-matching exceptions. This will misreport invalid SQL/chart config errors as "Unable to connect to the database." Remove this generic type from `_CONNECTION_ERROR_TYPES` (or add stricter checks on the extracted message/type) so only real connection/auth/network failures are classified as database connection errors. [incorrect condition logic]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ MCP generate_chart mislabels generic DB errors as connection failures.
- ⚠️ Preview-only compile checks report wrong root cause to users.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Call the MCP `generate_chart` tool, implemented at
`superset/mcp_service/chart/tool/generate_chart.py:93-153`, with a `GenerateChartRequest`
whose config produces a query-time database error that is not a connection/auth/network
issue (for example, an invalid SQL expression in a virtual dataset or an incompatible
aggregate), so that the underlying query fails at runtime.
2. When `generate_chart` runs the compile check after creating or preparing the chart, it
calls `_compile_chart(form_data, dataset.id)` in the saved-chart path at
`generate_chart.py:120-126` or in the preview-only path at `generate_chart.py:239-246`,
which routes into `_compile_chart` in `superset/mcp_service/chart/compile.py:133-205`.
3. Inside `_compile_chart` (`compile.py:156-205`), the `ChartDataCommand.run()` call can
raise `ChartDataQueryFailedError` (as defined in
`superset/commands/chart/exceptions.py:138-143` and raised in
`superset/commands/chart/data/get_data_command.py:15-22`) when `payload["queries"]`
contains an `"error"` string from the database; this exception is caught in the `except
(ChartDataQueryFailedError, ChartDataCacheLoadError) as exc` block at
`compile.py:206-226`.
4. In that exception handler, `_classify_as_database_error(exc, dataset_id)` is invoked
(`compile.py:206-208`). `_classify_as_database_error` (`compile.py:66-95`) calls
`dataset.database.db_engine_spec.extract_errors(exc)` (`compile.py:84-87`), which uses the
engine spec implementation `BaseEngineSpec.extract_errors` at
`superset/db_engine_specs/base.py:31-41`. When the error message doesn't match any custom
regex in `custom_errors` or `CUSTOM_DATABASE_ERRORS`, `extract_errors` returns a single
`SupersetError` with `error_type=SupersetErrorType.GENERIC_DB_ENGINE_ERROR` as its
fallback (`base.py:35-41`). Because `_CONNECTION_ERROR_TYPES` in `compile.py:52-65`
explicitly includes `SupersetErrorType.GENERIC_DB_ENGINE_ERROR`, the `any(e.error_type in
_CONNECTION_ERROR_TYPES for e in errors)` check at `compile.py:86-87` evaluates to True
even for non-connection engine errors, causing `_classify_as_database_error` to return
True and `_compile_chart` to treat the failure as a database connection error, returning
`_build_database_error(...)` (`compile.py:207-219)`. This produces a
`ChartGenerationError` with `error_type="database_connection_error"` and message `"Unable
to connect to the database."` (`compile.py:98-110`), which is then surfaced back to
`generate_chart` where `compile_result.error_obj` is used as the error payload
(`generate_chart.py:143-158` and `generate_chart.py:15-31`), misleading users into
thinking the database is unreachable when the underlying issue was a generic engine/SQL
error.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmcp_service%2Fchart%2Fcompile.py%0A%2A%2ALine%3A%2A%2A%2064%3A64%0A%2A%2AComment%3A%2A%2A%0A%09%2AIncorrect%20Condition%20Logic%3A%20Including%20%60GENERIC_DB_ENGINE_ERROR%60%20in%20the%20connection-only%20allowlist%20causes%20%60_classify_as_database_error%28%29%60%20to%20mark%20almost%20any%20compile%20failure%20as%20a%20database%20connectivity%20issue%2C%20because%20%60db_engine_spec.extract_errors%28%29%60%20falls%20back%20to%20%60GENERIC_DB_ENGINE_ERROR%60%20for%20non-matching%20exceptions.%20This%20will%20misreport%20invalid%20SQL%2Fchart%20config%20errors%20as%20%22Unable%20to%20connect%20to%20the%20database.%22%20Remove%20this%20generic%20type%20from%20%60_CONNECTION_ERROR_TYPES%60%20%28or%20add%20stricter%20checks%20on%20the%20extracted%20message%2Ftype%29%20so%20only%20real%20connection%2Fauth%2Fnetwork%20
failures%20are%20classified%20as%20database%20connection%20errors.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmcp_service%2Fchart%2Fcompile.py%0A%2A%2ALine%3A%2A%2A%2064%3A64%0A%2A%2AComment%3A%2A%2A%0A%09%2AIncorrect%20Condition%20Logic%3A%20Including%20%60GENERIC_DB_ENGINE_ERROR%60%20in%20the%20connection-only%20al
lowlist%20causes%20%60_classify_as_database_error%28%29%60%20to%20mark%20almost%20any%20compile%20failure%20as%20a%20database%20connectivity%20issue%2C%20because%20%60db_engine_spec.extract_errors%28%29%60%20falls%20back%20to%20%60GENERIC_DB_ENGINE_ERROR%60%20for%20non-matching%20exceptions.%20This%20will%20misreport%20invalid%20SQL%2Fchart%20config%20errors%20as%20%22Unable%20to%20connect%20to%20the%20database.%22%20Remove%20this%20generic%20type%20from%20%60_CONNECTION_ERROR_TYPES%60%20%28or%20add%20stricter%20checks%20on%20the%20extracted%20message%2Ftype%29%20so%20only%20real%20connection%2Fauth%2Fnetwork%20failures%20are%20classified%20as%20database%20connection%20errors.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20a
sk%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/compile.py
**Line:** 64:64
**Comment:**
*Incorrect Condition Logic: Including `GENERIC_DB_ENGINE_ERROR` in the connection-only allowlist causes `_classify_as_database_error()` to mark almost any compile failure as a database connectivity issue, because `db_engine_spec.extract_errors()` falls back to `GENERIC_DB_ENGINE_ERROR` for non-matching exceptions. This will misreport invalid SQL/chart config errors as "Unable to connect to the database." Remove this generic type from `_CONNECTION_ERROR_TYPES` (or add stricter checks on the extracted message/type) so only real connection/auth/network failures are classified as database connection errors.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39964&comment_hash=aab795e81425d03374103a8bbfa76cc30b37f92334b35b7272118283192f1dde&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39964&comment_hash=aab795e81425d03374103a8bbfa76cc30b37f92334b35b7272118283192f1dde&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "alexandrusoare (via GitHub)" <gi...@apache.org>.
alexandrusoare commented on code in PR #39964:
URL: https://github.com/apache/superset/pull/39964#discussion_r3208214147
##########
superset/mcp_service/chart/compile.py:
##########
@@ -46,6 +49,21 @@
logger = logging.getLogger(__name__)
+_CONNECTION_ERROR_TYPES = {
+ SupersetErrorType.CONNECTION_INVALID_USERNAME_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PASSWORD_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR,
+ SupersetErrorType.CONNECTION_PORT_CLOSED_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PORT_ERROR,
+ SupersetErrorType.CONNECTION_HOST_DOWN_ERROR,
+ SupersetErrorType.CONNECTION_ACCESS_DENIED_ERROR,
+ SupersetErrorType.CONNECTION_UNKNOWN_DATABASE_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_PERMISSIONS_ERROR,
+ SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_TIMEOUT,
+ SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
Review Comment:
We include GENERIC_DB_ENGINE_ERROR because many engines (BigQuery, Snowflake, Athena, Databricks, Trino) lack specific CONNECTION_* regex patterns — all their connection failures fall back to this type. Excluding it would mean connection errors on these databases still show as "chart configuration is invalid," defeating the purpose of this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39964:
URL: https://github.com/apache/superset/pull/39964#issuecomment-4405080991
<!-- Bito Reply -->
The flagged issue is correct: including GENERIC_DB_ENGINE_ERROR in _CONNECTION_ERROR_TYPES causes _classify_as_database_error to misclassify non-connection errors as database connectivity issues, since extract_errors falls back to it for unmatched exceptions. Removing GENERIC_DB_ENGINE_ERROR from the set improves accuracy by limiting connection error classification to specific types. Here's the updated code snippet for _CONNECTION_ERROR_TYPES:
**superset/mcp_service/chart/compile.py**
```
_CONNECTION_ERROR_TYPES = {
SupersetErrorType.CONNECTION_INVALID_USERNAME_ERROR,
SupersetErrorType.CONNECTION_INVALID_PASSWORD_ERROR,
SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR,
SupersetErrorType.CONNECTION_PORT_CLOSED_ERROR,
SupersetErrorType.CONNECTION_INVALID_PORT_ERROR,
SupersetErrorType.CONNECTION_HOST_DOWN_ERROR,
SupersetErrorType.CONNECTION_ACCESS_DENIED_ERROR,
SupersetErrorType.CONNECTION_UNKNOWN_DATABASE_ERROR,
SupersetErrorType.CONNECTION_DATABASE_PERMISSIONS_ERROR,
SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
SupersetErrorType.CONNECTION_DATABASE_TIMEOUT,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #39964:
URL: https://github.com/apache/superset/pull/39964#discussion_r3207576034
##########
superset/mcp_service/chart/compile.py:
##########
@@ -278,6 +322,53 @@ def _validate_adhoc_filter_columns(
)
+def _classify_as_database_error(exc: BaseException, dataset_id: int) -> bool:
+ """Use the dataset's DB engine spec to classify the error.
+
+ Walks the ``__cause__`` chain for direct ``SQLAlchemyError`` instances,
+ then falls back to the engine spec's ``extract_errors`` regex patterns —
+ the same classification the Superset UI uses.
+ """
+ # Direct SQLAlchemy errors (unwrapped or in cause chain)
+ current: BaseException | None = exc
+ while current is not None:
+ if isinstance(current, SQLAlchemyError):
+ return True
+ current = current.__cause__
+
+ # Use the dataset's engine spec to classify (same as the UI)
+ try:
+ from superset.daos.dataset import DatasetDAO
+
+ dataset = DatasetDAO.find_by_id(dataset_id)
+ if dataset and dataset.database and isinstance(exc, Exception):
+ errors = dataset.database.db_engine_spec.extract_errors(exc)
+ return any(e.error_type in _CONNECTION_ERROR_TYPES for e in errors)
+ except Exception: # pylint: disable=broad-except
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Overly broad exception catch blocks</b></div>
<div id="fix">
Line 347 catches bare `Exception` which is too broad. Catch specific exception types instead (e.g., `AttributeError`, `KeyError`, `TypeError`) to avoid masking unexpected errors.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
except (AttributeError, KeyError, TypeError):
````
</div>
</details>
</div>
<small><i>Code Review Run #487b42</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "alexandrusoare (via GitHub)" <gi...@apache.org>.
alexandrusoare merged PR #39964:
URL: https://github.com/apache/superset/pull/39964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39964:
URL: https://github.com/apache/superset/pull/39964#discussion_r3208216900
##########
superset/mcp_service/chart/compile.py:
##########
@@ -46,6 +49,21 @@
logger = logging.getLogger(__name__)
+_CONNECTION_ERROR_TYPES = {
+ SupersetErrorType.CONNECTION_INVALID_USERNAME_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PASSWORD_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR,
+ SupersetErrorType.CONNECTION_PORT_CLOSED_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PORT_ERROR,
+ SupersetErrorType.CONNECTION_HOST_DOWN_ERROR,
+ SupersetErrorType.CONNECTION_ACCESS_DENIED_ERROR,
+ SupersetErrorType.CONNECTION_UNKNOWN_DATABASE_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_PERMISSIONS_ERROR,
+ SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_TIMEOUT,
+ SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Keep `SupersetErrorType.GENERIC_DB_ENGINE_ERROR` in the connection-error allowlist for chart compilation so engines without specific `CONNECTION_*` patterns still surface real database connection failures correctly.
**Applied to:**
- `superset/mcp_service/chart/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39964:
URL: https://github.com/apache/superset/pull/39964#issuecomment-4405099745
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39964?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `17.85714%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.25%. Comparing base ([`5b5dd01`](https://app.codecov.io/gh/apache/superset/commit/5b5dd010285890b4b5b45e707a9c3b0da413f75e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2c2aaa7`](https://app.codecov.io/gh/apache/superset/commit/2c2aaa7fc221360c0eae05869e833fe3be241768?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 11 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/39964?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/mcp\_service/chart/compile.py](https://app.codecov.io/gh/apache/superset/pull/39964?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Fcompile.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvY29tcGlsZS5weQ==) | 19.23% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/39964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/mcp\_service/chart/tool/generate\_chart.py](https://app.codecov.io/gh/apache/superset/pull/39964?src=pr&el=tree&filepath=superset%2Fmcp_service%2Fchart%2Ftool%2Fgenerate_chart.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbWNwX3NlcnZpY2UvY2hhcnQvdG9vbC9nZW5lcmF0ZV9jaGFydC5weQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/39964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39964 +/- ##
==========================================
- Coverage 63.88% 63.25% -0.64%
==========================================
Files 2583 2583
Lines 136604 136651 +47
Branches 31502 31508 +6
==========================================
- Hits 87276 86443 -833
- Misses 47812 48677 +865
- Partials 1516 1531 +15
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.36% <17.85%> (-0.03%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.09% <17.85%> (-0.05%)` | :arrow_down: |
| [presto](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.06% <17.85%> (-0.03%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.21% <17.85%> (-1.37%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/39964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39964?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39964:
URL: https://github.com/apache/superset/pull/39964#issuecomment-4405005755
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39964:
URL: https://github.com/apache/superset/pull/39964#issuecomment-4407835220
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(mcp): raise right error [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39964:
URL: https://github.com/apache/superset/pull/39964#issuecomment-4405019500
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 2c2aaa7fc221360c0eae05869e833fe3be241768 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69fda1e2f189e500084d3830 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39964--superset-docs-preview.netlify.app](https://deploy-preview-39964--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBDoIwEAXQu8waQhElhRt4jKEz1SbQaT6YYAx3t7u3eT8qsK0cNBM1tIBzeFfzqidnwWc3hnYxnV0waDhaBQwtOO0pv2oRLat9n1LTOEXhXm-x95M-nHP-LoMfHF1_) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-39964--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org