You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/17 15:11:54 UTC

[GitHub] [systemds] whirgod commented on pull request #1275: Image Manipulation Primitives

whirgod commented on pull request #1275:
URL: https://github.com/apache/systemds/pull/1275#issuecomment-842405257


   > Hello and thank you for your effort in this PR!
   > In general I agree with Sebastian, it looks good, but if I may chime in with additional questions:
   > Why is Pillow used? I'm sure there are image manipulation libraries for R and Java that could be used.
   > I guess the use of Pillow is the reason for the additional resource files and the methods in TestUtils? That (and the mentioned precision issues) could be avoided by using an R or Java library for comparison.
   > jm2c ;-)
   > Mark
   
   I use Pillow as a reference because one of the reasons I added the builtins is to reproduce the results of AutoAugment (https://arxiv.org/abs/1805.09501) and they use Pillow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org