[GitHub] bytenik commented on a change in pull request #167: Move check for showSplashScreen outside of showAndHide

[GitBox <gi...@apache.org>]

bytenik commented on a change in pull request #167: Move check for showSplashScreen outside of showAndHide
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/167#discussion_r229688271
 
 

 ##########
 File path: src/browser/SplashScreenProxy.js
 ##########
 @@ -138,13 +138,11 @@ function readPreferencesFromCfg(cfg) {
  * Shows and hides splashscreen if it is enabled, with a delay according the current preferences.
  */
 function showAndHide() {
 
 Review comment:
   Its certainly possible that someone externally uses this and depends on the broken behavior. The only way to avoid that for certain would be to keep the if in this function and then also check for enabled in the caller when autohide is disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org