You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 10:16:01 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #2496: Use u8 for Decimal Precision and Scale
tustvold opened a new issue, #2496:
URL: https://github.com/apache/arrow-rs/issues/2496
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
The maximum precision and scale for decimal types is 76, and yet we consume an entire `usize` to store this information. This is most pronounced on `BasicDecimal` where the precision and scale take up more memory than the actual value data :scream:
**Describe the solution you'd like**
<!--
A clear and concise description of what you want to happen.
-->
I would like to propose using `u8` for these instead of `usize`
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
Thoughts @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #2496: Use u8 for Decimal Precision and Scale
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2496:
URL: https://github.com/apache/arrow-rs/issues/2496#issuecomment-1220181887
It's reasonable for me.
I think the data type of `Decimal128(usize, usize),` should be changed too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2496: Use u8 for Decimal Precision and Scale
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2496: Use u8 for Decimal Precision and Scale
URL: https://github.com/apache/arrow-rs/issues/2496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #2496: Use u8 for Decimal Precision and Scale
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2496:
URL: https://github.com/apache/arrow-rs/issues/2496#issuecomment-1221250915
> It's reasonable for me. I think the data type of `Decimal128(usize, usize),` should be changed too
Do you have some comments about the data type of the decimal128?
FYI @psvri @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] psvri commented on issue #2496: Use u8 for Decimal Precision and Scale
Posted by GitBox <gi...@apache.org>.
psvri commented on issue #2496:
URL: https://github.com/apache/arrow-rs/issues/2496#issuecomment-1221252544
I have changed datatype to Decimal128(u8, u8) and Decimal256(u8, u8) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] psvri commented on issue #2496: Use u8 for Decimal Precision and Scale
Posted by GitBox <gi...@apache.org>.
psvri commented on issue #2496:
URL: https://github.com/apache/arrow-rs/issues/2496#issuecomment-1220339721
Hello,
I will pick this up if no one has started working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org