You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/03/14 17:16:08 UTC

[GitHub] [couchdb] nickva commented on a change in pull request #1972: Introduce Shard Splitting To CouchDB

nickva commented on a change in pull request #1972: Introduce Shard Splitting To CouchDB
URL: https://github.com/apache/couchdb/pull/1972#discussion_r265677665
 
 

 ##########
 File path: src/couch/src/couch_db_engine.erl
 ##########
 @@ -465,6 +474,13 @@
         {ok, NewDbHandle::db_handle()}.
 
 
+% This function should be called from a single threaded context and
+% should be used to copy purge infos from on database to another
+% when copying a database
+-callback copy_purge_infos(DbHandle::db_handle(), [purge_info()]) ->
+        {ok, NewDbHandle::db_handle()}.
 
 Review comment:
   It's two level to match match existing indentation for callbacks specs. (Two levels for the response to break it up from one level indentation for when the function head is too long).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services