You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/27 08:12:33 UTC
[GitHub] [arrow] JkSelf opened a new pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
JkSelf opened a new pull request #9334:
URL: https://github.com/apache/arrow/pull/9334
When using Arrow as the 3rd library, it is hard to add the custom function due to the private access permission.
This PR update the private access permission from private to protected. Then we can easily expand new functions in the subclass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] JkSelf commented on pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
JkSelf commented on pull request #9334:
URL: https://github.com/apache/arrow/pull/9334#issuecomment-772333244
Yes, this approach may be not perfect. Arrow 3.0 can decompress the compressed buffer firstly and then load the decompressed buffer into the FieldVector, which can resolve the [issue](https://issues.apache.org/jira/browse/ARROW-8803). And I will close this PR.
Thanks for your discussion again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] JkSelf commented on pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
JkSelf commented on pull request #9334:
URL: https://github.com/apache/arrow/pull/9334#issuecomment-770719454
@emkornfield Thanks for you reviewing.
We compressed the body buffers in native by calling c++ buffer comoression API and then read the RecordBatch with the compressed buffers using Java's IPC API based on the 0.17 version. And we block [this issue](https://issues.apache.org/jira/browse/ARROW-8803). So we resolved with this patch. It seems the compress and decompress framework already done in [ARROW-9010](https://issues.apache.org/jira/browse/ARROW-9010). So this PR may be not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9334:
URL: https://github.com/apache/arrow/pull/9334#issuecomment-770164249
I think there is likely a better design than this. Could you articulate the concrete use-case (it looks like it has something to do with compression)? At the very least, if we make these protected then we need to add javadoc on the contract that is intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9334:
URL: https://github.com/apache/arrow/pull/9334#issuecomment-772217414
OK, but I'm still not sure this is the correct approach? It seems if you want to plugin in a custom codec then there should be a change to VectorLoader to take a decompressor factory (VectorUnloader can already specify a code for compression)? Or do all decompression with native code and then share the record batch memory back with Java?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9334:
URL: https://github.com/apache/arrow/pull/9334#issuecomment-768113790
https://issues.apache.org/jira/browse/ARROW-11396
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] JkSelf closed pull request #9334: ARROW-11396: [JAVA] Update the private access permission from private to protected
Posted by GitBox <gi...@apache.org>.
JkSelf closed pull request #9334:
URL: https://github.com/apache/arrow/pull/9334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org