[GitHub] [spark] eejbyfeldt commented on pull request #27153: [SPARK-20384][SQL] Support value class in schema of Dataset (without breaking existing current projection)

[GitBox <gi...@apache.org>]

eejbyfeldt commented on pull request #27153:
URL: https://github.com/apache/spark/pull/27153#issuecomment-856536881


   I am interested in support for value classes that is added/fixed in this branch. To me the changes looks like they are a still valid approach of adding the support. 
   
   Rebasing this branch on master while cause some of the added test cases to fail. This is due to a PR https://github.com/apache/spark/pull/31766 the fixed the so that interpreted path test are run properly and a bug for
   CatalystToExternalMap in the interpreted path. I created a PR here to address that bug here: https://github.com/apache/spark/pull/32783
   
   If/after the bug fix gets merged, would the next step towards getting this merged? Should I open a new PR with the changes from @mickjermsurawong-stripe branch? Since to me it looks like the original author is no longer around and/or interested in these changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org