You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/24 14:01:53 UTC
[GitHub] [spark] olaky opened a new pull request, #36654: [WIP][SPARK-39259] Evaluate timestamps consistently in subqueries
olaky opened a new pull request, #36654:
URL: https://github.com/apache/spark/pull/36654
### What changes were proposed in this pull request?
Apply the optimizer rule ComputeCurrentTime consistently across subqueries
### Why are the changes needed?
At the moment timestamp functions like now() can return different values within a query if subqueries are involved
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
A new unit test was added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] olaky commented on a diff in pull request #36654: [SPARK-39259] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
olaky commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r883695110
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
+
+ /** Required to build custom rules for commands that do not keep sub-plans as children in Delta */
Review Comment:
I refer to open source Delta. Command like [MergeIntoCommand](https://github.com/delta-io/delta/blob/532da849290f9fa63ccacfc176f39f6d4775035d/core/src/main/scala/org/apache/spark/sql/delta/commands/MergeIntoCommand.scala#L206) do not have source added a children, and this is also not possible to add easily. This is why the solution I am going for is a special rule which applies this code with a shared timestamp. For this rule, I would like to re-use the code from here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] olaky commented on a diff in pull request #36654: [SPARK-39259] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
olaky commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r883695655
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
+
+ /** Required to build custom rules for commands that do not keep sub-plans as children in Delta */
+ def applyWithTimestamp(plan: LogicalPlan, instant: Instant): LogicalPlan = {
+ val currentTimestamp = instantToMicros(instant)
Review Comment:
The idea here is to be able to apply this code to multiple plans using the same instant (see comment above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JoshRosen commented on pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
JoshRosen commented on PR #36654:
URL: https://github.com/apache/spark/pull/36654#issuecomment-1146483609
This looks like it might be a fix for a correctness issue? If so, we should probably backport this change to maintenance branches for the other currently-supported Spark versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JoshRosen commented on a diff in pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
JoshRosen commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r889431243
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -479,21 +479,24 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
* first to this node, then this node's subqueries and finally this node's children.
* When the partial function does not apply to a given node, it is left unchanged.
*/
- def transformDownWithSubqueries(f: PartialFunction[PlanType, PlanType]): PlanType = {
+ def transformDownWithSubqueries(
Review Comment:
Instead of modifying this method's signature, I slightly prefer adding an overload named `transformDownWithSubqueriesAndPruning` in order to remain consistent with the naming conventions for other transform methods.
Adding a new method also avoids introducing source or binary compatibility issues for third-party code that calls Catalyst APIs. Technically speaking, Catalyst APIs are considered internal to Spark and are subject to change between minor releases (see [source](https://github.com/apache/spark/blob/bb51add5c79558df863d37965603387d40cc4387/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/package.scala#L20-L24)), but I think it's nice to try to avoid API breakage when feasible.
I also ran into problems when trying to call `transformDownWithSubqueries` without supplying any arguments in the first argument group: calling `transformDownWithSubqueries() { f }` resulted in confusing compilation errors.
As a result, I'm going to submit a followup to this PR to split this into two methods as I've suggested above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JoshRosen commented on a diff in pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
JoshRosen commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r889432632
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -479,21 +479,24 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
* first to this node, then this node's subqueries and finally this node's children.
* When the partial function does not apply to a given node, it is left unchanged.
*/
- def transformDownWithSubqueries(f: PartialFunction[PlanType, PlanType]): PlanType = {
+ def transformDownWithSubqueries(
Review Comment:
Here's my PR: https://github.com/apache/spark/pull/36765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #36654: [SPARK-39259] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r883621685
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
+
+ /** Required to build custom rules for commands that do not keep sub-plans as children in Delta */
+ def applyWithTimestamp(plan: LogicalPlan, instant: Instant): LogicalPlan = {
+ val currentTimestamp = instantToMicros(instant)
Review Comment:
Maybe, just invoke DateTimeUtils.currentTimestamp()
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
+
+ /** Required to build custom rules for commands that do not keep sub-plans as children in Delta */
Review Comment:
In Delta? Do you refer to open source Delta or Databricks Delta. In any case, we shouldn't do that, I think.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
Review Comment:
Could you inline `applyWithTimestamp`, please, since it is used only once here.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -72,30 +73,34 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
* Computes the current date and time to make sure we return the same result in a single query.
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
- def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ def apply(plan: LogicalPlan): LogicalPlan = applyWithTimestamp(plan, Instant.now())
+
+ /** Required to build custom rules for commands that do not keep sub-plans as children in Delta */
+ def applyWithTimestamp(plan: LogicalPlan, instant: Instant): LogicalPlan = {
+ val currentTimestamp = instantToMicros(instant)
+ val currentTime = Literal.create(currentTimestamp, TimestampType)
val timezone = Literal.create(conf.sessionLocalTimeZone, StringType)
- val localTimestamps = mutable.Map.empty[String, Literal]
- plan.transformAllExpressionsWithPruning(_.containsPattern(CURRENT_LIKE)) {
- case currentDate @ CurrentDate(Some(timeZoneId)) =>
- currentDates.getOrElseUpdate(timeZoneId, {
- Literal.create(currentDate.eval().asInstanceOf[Int], DateType)
- })
- case CurrentTimestamp() | Now() => currentTime
- case CurrentTimeZone() => timezone
- case localTimestamp @ LocalTimestamp(Some(timeZoneId)) =>
- localTimestamps.getOrElseUpdate(timeZoneId, {
- Literal.create(localTimestamp.eval().asInstanceOf[Long], TimestampNTZType)
- })
+ def transformCondition(treePatternbits: TreePatternBits): Boolean = {
+ treePatternbits.containsPattern(CURRENT_LIKE)
+ }
+
+ plan.transformDownWithSubqueries(transformCondition) {
+ case subQuery =>
+ subQuery.transformAllExpressionsWithPruning(transformCondition) {
+ case cd: CurrentDate =>
+ Literal.create(
+ localDateToDays(instant.atZone(cd.zoneId).toLocalDate).asInstanceOf[Int], DateType)
Review Comment:
Can't you re-use DateTimeUtils.microsToDays() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36654:
URL: https://github.com/apache/spark/pull/36654#issuecomment-1145197543
@olaky Could you open a separate PRs with backports to branch-3.3 and branch-3.2 (according to SPARK-39259, 3.2 has this issue).
Congratulations with the first contribution to Apache Spark, and welcome to Spark community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
URL: https://github.com/apache/spark/pull/36654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36654: [WIP][SPARK-39259] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36654:
URL: https://github.com/apache/spark/pull/36654#issuecomment-1138095572
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #36654:
URL: https://github.com/apache/spark/pull/36654#discussion_r887935173
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -73,29 +75,32 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ val instant = Instant.now()
+ val currentTimestampMicros = instantToMicros(instant)
+ val currentTime = Literal.create(currentTimestampMicros, TimestampType)
val timezone = Literal.create(conf.sessionLocalTimeZone, StringType)
- val localTimestamps = mutable.Map.empty[String, Literal]
- plan.transformAllExpressionsWithPruning(_.containsPattern(CURRENT_LIKE)) {
- case currentDate @ CurrentDate(Some(timeZoneId)) =>
- currentDates.getOrElseUpdate(timeZoneId, {
- Literal.create(currentDate.eval().asInstanceOf[Int], DateType)
- })
- case CurrentTimestamp() | Now() => currentTime
- case CurrentTimeZone() => timezone
- case localTimestamp @ LocalTimestamp(Some(timeZoneId)) =>
- localTimestamps.getOrElseUpdate(timeZoneId, {
- Literal.create(localTimestamp.eval().asInstanceOf[Long], TimestampNTZType)
- })
+ def transformCondition(treePatternbits: TreePatternBits): Boolean = {
+ treePatternbits.containsPattern(CURRENT_LIKE)
+ }
+
+ plan.transformDownWithSubqueries(transformCondition) {
+ case subQuery =>
+ subQuery.transformAllExpressionsWithPruning(transformCondition) {
+ case cd: CurrentDate =>
+ Literal.create(
+ DateTimeUtils.microsToDays(currentTimestampMicros, cd.zoneId).asInstanceOf[Int],
+ DateType)
+ case CurrentTimestamp() | Now() => currentTime
+ case CurrentTimeZone() => timezone
+ case localTimestamp: LocalTimestamp =>
+ val asDateTime = LocalDateTime.ofInstant(instant, localTimestamp.zoneId)
+ Literal.create(localDateTimeToMicros(asDateTime).asInstanceOf[Long], TimestampNTZType)
Review Comment:
Please, remove `.asInstanceOf[Long]`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -73,29 +75,32 @@ object RewriteNonCorrelatedExists extends Rule[LogicalPlan] {
*/
object ComputeCurrentTime extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
- val currentDates = mutable.Map.empty[String, Literal]
- val timeExpr = CurrentTimestamp()
- val timestamp = timeExpr.eval(EmptyRow).asInstanceOf[Long]
- val currentTime = Literal.create(timestamp, timeExpr.dataType)
+ val instant = Instant.now()
+ val currentTimestampMicros = instantToMicros(instant)
+ val currentTime = Literal.create(currentTimestampMicros, TimestampType)
val timezone = Literal.create(conf.sessionLocalTimeZone, StringType)
- val localTimestamps = mutable.Map.empty[String, Literal]
- plan.transformAllExpressionsWithPruning(_.containsPattern(CURRENT_LIKE)) {
- case currentDate @ CurrentDate(Some(timeZoneId)) =>
- currentDates.getOrElseUpdate(timeZoneId, {
- Literal.create(currentDate.eval().asInstanceOf[Int], DateType)
- })
- case CurrentTimestamp() | Now() => currentTime
- case CurrentTimeZone() => timezone
- case localTimestamp @ LocalTimestamp(Some(timeZoneId)) =>
- localTimestamps.getOrElseUpdate(timeZoneId, {
- Literal.create(localTimestamp.eval().asInstanceOf[Long], TimestampNTZType)
- })
+ def transformCondition(treePatternbits: TreePatternBits): Boolean = {
+ treePatternbits.containsPattern(CURRENT_LIKE)
+ }
+
+ plan.transformDownWithSubqueries(transformCondition) {
+ case subQuery =>
+ subQuery.transformAllExpressionsWithPruning(transformCondition) {
+ case cd: CurrentDate =>
+ Literal.create(
+ DateTimeUtils.microsToDays(currentTimestampMicros, cd.zoneId).asInstanceOf[Int],
Review Comment:
I think this `.asInstanceOf[Int]` since `microsToDays()` return Int
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36654:
URL: https://github.com/apache/spark/pull/36654#issuecomment-1145192596
+1, LGTM. Merging to master, 3.3, 3.2.
Thank you, @olaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36654: [SPARK-39259][SQL] Evaluate timestamps consistently in subqueries
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36654:
URL: https://github.com/apache/spark/pull/36654#issuecomment-1145192594
+1, LGTM. Merging to master, 3.3, 3.2.
Thank you, @olaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org