You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/09/27 22:56:32 UTC

[GitHub] [geode] PurelyApplied opened pull request #2532: [Discuss:] Eliminating transitive dependencies.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2532 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2532: [Discuss:] Eliminating transitive dependencies.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
This PR generated good discussion, as was its intent.  See [the dev list mail archive](https://lists.apache.org/thread.html/a75cf0b38e2892bdbd75850134a2af17b2f1434275f473c034852154@%3Cdev.geode.apache.org%3E) for details.

I will close this PR now and spin out smaller, more manageable PRs from this one for actual consideration to commit.

[ Full content available at: https://github.com/apache/geode/pull/2532 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2532: [Discuss:] Eliminating transitive dependencies.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Please note that this PR is meant as a general discussion point.  I fully expect many tests to fail, with actual dependencies hidden in reflection calls, etc.  There will undoubtedly be additional iteration towards the "right" configuration of the source sets for each target.

[ Full content available at: https://github.com/apache/geode/pull/2532 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2532: [Discuss:] Eliminating transitive dependencies.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2532 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org