You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/12 08:53:43 UTC
Review Request 39219: Windows: Added support for `slave/state.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 18, 2015, 5:13 p.m., Joris Van Remoortere wrote:
> > src/slave/state.hpp, line 132
> > <https://reviews.apache.org/r/39219/diff/3/?file=1099151#file1099151line132>
> >
> > How is this compiling for you?
Per our discussion, this turns out to not manifested because (1) there is no template specialization that would cause it to manifest in the CMake build, and (2) I didn't do a make clean before I built this on my Ubuntu box.
It's good to know that I can't expect some errors to be caught until specialization though! That blows my mind.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review103062
-----------------------------------------------------------
On Oct. 18, 2015, 6:40 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2015, 6:40 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3627
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3633
> https://issues.apache.org/jira/browse/MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3659
> https://issues.apache.org/jira/browse/MESOS-3660
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review103062
-----------------------------------------------------------
src/slave/state.hpp (line 131)
<https://reviews.apache.org/r/39219/#comment160923>
How is this compiling for you?
src/slave/state.cpp (line 650)
<https://reviews.apache.org/r/39219/#comment160920>
`isError()` reads better.
src/slave/state.cpp (lines 652 - 653)
<https://reviews.apache.org/r/39219/#comment160921>
We now have an error to return from the `Try`
src/slave/state.cpp (lines 730 - 733)
<https://reviews.apache.org/r/39219/#comment160922>
Same as above.
- Joris Van Remoortere
On Oct. 15, 2015, 8:31 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 8:31 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3627
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3633
> https://issues.apache.org/jira/browse/MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3659
> https://issues.apache.org/jira/browse/MESOS-3660
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote:
> > src/slave/state.cpp, lines 39-43
> > <https://reviews.apache.org/r/39219/diff/6/?file=1125974#file1125974line39>
> >
> > what about `<stout/os/close.hpp>`?
You committed it already, so, uh, well, I guess we'll get it next time.
#ThanksForPaddingMyNumberOfCommits
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote:
> > src/slave/state.cpp, lines 39-43
> > <https://reviews.apache.org/r/39219/diff/6/?file=1125974#file1125974line39>
> >
> > what about `<stout/os/close.hpp>`?
>
> Alex Clemmer wrote:
> You committed it already, so, uh, well, I guess we'll get it next time.
>
> #ThanksForPaddingMyNumberOfCommits
Ooops. #WhenYourHashtagsGetInterpretedAsMarkdownHeaders
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review109654
-----------------------------------------------------------
Ship it!
src/slave/state.cpp (lines 36 - 40)
<https://reviews.apache.org/r/39219/#comment169249>
what about `<stout/os/close.hpp>`?
- Joris Van Remoortere
On Dec. 10, 2015, 1:27 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 1:27 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3615
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 1:27 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3615
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:13 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 5:54 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 6:24 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Oct. 18, 2015, 6:40 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Oct. 15, 2015, 8:31 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review102522
-----------------------------------------------------------
Ship it!
src/slave/state.cpp (line 648)
<https://reviews.apache.org/r/39219/#comment160213>
Per a comment in a previous review:
s/chsize/ftruncate/
src/slave/state.cpp (line 728)
<https://reviews.apache.org/r/39219/#comment160214>
Per a comment in a previous review:
s/chsize/ftruncate/
- Joseph Wu
On Oct. 13, 2015, 11:35 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 11:35 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3627
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3633
> https://issues.apache.org/jira/browse/MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3659
> https://issues.apache.org/jira/browse/MESOS-3660
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `slave/state.cpp`.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
>
> Diff: https://reviews.apache.org/r/39219/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39219: Windows: Added support for
`slave/state.cpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:35 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `slave/state.cpp`.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39219/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer