You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/05 10:15:10 UTC
[GitHub] [iotdb-client-go] HTHou opened a new pull request #7: Try to fix Github actions
HTHou opened a new pull request #7:
URL: https://github.com/apache/iotdb-client-go/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-client-go] jixuan1989 merged pull request #7: Try to fix Github actions
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #7:
URL: https://github.com/apache/iotdb-client-go/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-client-go] HTHou commented on a change in pull request #7: Try to fix Github actions
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #7:
URL: https://github.com/apache/iotdb-client-go/pull/7#discussion_r551949535
##########
File path: .github/workflows/go.yml
##########
@@ -6,22 +6,47 @@ on:
pull_request:
branches: [ main ]
-jobs:
+env:
+ TZ: Asia/Shanghai
+jobs:
build:
name: Build
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [macos-latest, ubuntu-latest, windows-latest]
+ os: [macos-latest, ubuntu-latest]
steps:
- - name: Setup timezone
- uses: szenius/set-timezone@v1.0
+ - name: Set up Go 1.x
+ uses: actions/setup-go@v2
with:
- timezoneLinux: "Asia/Shanghai"
- timezoneMacos: "Asia/Shanghai"
- timezoneWindows: "China Standard Time"
+ go-version: ^1.13
+
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+
+ - name: Get dependencies
+ run: |
+ go get -v -t -d ./...
+ # if [ -f Gopkg.toml ]; then
Review comment:
These lines are copied from the previous code. I don't think it's useful. Let me remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-client-go] jixuan1989 commented on a change in pull request #7: Try to fix Github actions
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #7:
URL: https://github.com/apache/iotdb-client-go/pull/7#discussion_r551948215
##########
File path: .github/workflows/go.yml
##########
@@ -6,22 +6,47 @@ on:
pull_request:
branches: [ main ]
-jobs:
+env:
+ TZ: Asia/Shanghai
+jobs:
build:
name: Build
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [macos-latest, ubuntu-latest, windows-latest]
+ os: [macos-latest, ubuntu-latest]
steps:
- - name: Setup timezone
- uses: szenius/set-timezone@v1.0
+ - name: Set up Go 1.x
+ uses: actions/setup-go@v2
with:
- timezoneLinux: "Asia/Shanghai"
- timezoneMacos: "Asia/Shanghai"
- timezoneWindows: "China Standard Time"
+ go-version: ^1.13
+
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+
+ - name: Get dependencies
+ run: |
+ go get -v -t -d ./...
+ # if [ -f Gopkg.toml ]; then
Review comment:
any intention for these comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb-client-go] HTHou commented on a change in pull request #7: Try to fix Github actions
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #7:
URL: https://github.com/apache/iotdb-client-go/pull/7#discussion_r551949535
##########
File path: .github/workflows/go.yml
##########
@@ -6,22 +6,47 @@ on:
pull_request:
branches: [ main ]
-jobs:
+env:
+ TZ: Asia/Shanghai
+jobs:
build:
name: Build
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [macos-latest, ubuntu-latest, windows-latest]
+ os: [macos-latest, ubuntu-latest]
steps:
- - name: Setup timezone
- uses: szenius/set-timezone@v1.0
+ - name: Set up Go 1.x
+ uses: actions/setup-go@v2
with:
- timezoneLinux: "Asia/Shanghai"
- timezoneMacos: "Asia/Shanghai"
- timezoneWindows: "China Standard Time"
+ go-version: ^1.13
+
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+
+ - name: Get dependencies
+ run: |
+ go get -v -t -d ./...
+ # if [ -f Gopkg.toml ]; then
Review comment:
These lines are copied from the previous code. I don't think it useful. Let me remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org