You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by koeninger <gi...@git.apache.org> on 2018/11/21 16:46:04 UTC
[GitHub] spark pull request #23103: [SPARK-26121] [Structured Streaming] Allow users ...
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/23103#discussion_r235461374
--- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala ---
@@ -538,6 +538,17 @@ private[kafka010] object KafkaSourceProvider extends Logging {
.setIfUnset(ConsumerConfig.RECEIVE_BUFFER_CONFIG, 65536: java.lang.Integer)
.build()
+ /**
+ * Returns a unique consumer group (group.id), allowing the user to set the prefix of
+ * the consumer group
+ */
+ private def streamingUniqueGroupId(parameters: Map[String, String],
--- End diff --
Sorry there isn't an automatic formatter for this... but use 4 space indentation for multi-line argument lists
https://github.com/databricks/scala-style-guide#spacing-and-indentation
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org