You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/17 21:50:28 UTC
[GitHub] [calcite] laurentgo opened a new pull request #2112: [CALCITE-4025] Fix early exit in DelegatingScope#fullyQualify
laurentgo opened a new pull request #2112:
URL: https://github.com/apache/calcite/pull/2112
Address an issue in fullyQualify method when fully qualifying an
identifier and the prefix cannot be resolved but could if name matching
was not case sensitive, the method would throw an exception instead of
trying to continue matching smaller prefixes (in case of compound
columns keys).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zinking commented on pull request #2112: [CALCITE-4025] Fix early exit in DelegatingScope#fullyQualify
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2112:
URL: https://github.com/apache/calcite/pull/2112#issuecomment-677649948
LGTM, except I would "" empty string instead of `null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] laurentgo commented on pull request #2112: [CALCITE-4025] Fix early exit in DelegatingScope#fullyQualify
Posted by GitBox <gi...@apache.org>.
laurentgo commented on pull request #2112:
URL: https://github.com/apache/calcite/pull/2112#issuecomment-677901473
I'm assuming you meant for this piece of code?
```
// to capture possible suggestion if no table alias found
SqlIdentifier suggestionPrefix = null;
String suggestionName = null;
```
I'm not sure why an empty string would be a better choice here. There's no safety issue, and `null` captures the absence of a match clearly (vs a suggestion which would be an empty table name).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org