You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:37:59 UTC
[GitHub] [cloudstack-primate] PaulAngus opened a new issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
PaulAngus opened a new issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487
**Describe the bug**
A 'Backup' tab is shown under storage when the Backup Framework has not been enabled. This will cause many 'support calls' when users want try to create backups.
**To Reproduce**
Steps to reproduce the behavior:
1. Ensure backup framework is not enabled
2. Click on 'Storage' tab
4. See error
**Expected behavior**
The backup tab should not be visible as the backup framework is not enabled.
**Screenshots**
**Desktop (please complete the following information):**
- OS: [e.g. Windows, Mac, iOS, Android with device/screen details if applicable]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-654118182
With @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653832217
With @davidjumani
- Remove the view backup and vmsnapshot button via config::related for compute.js
- Instead add tabs to the VM instance/detail component to show/hide both backup and vm snapshots (similar to the volumes, nics etc tabs) depending on user-role access and availability of feature
@PaulAngus Lowering severity to Major, we'll fix the issue for 1.0/GA but let's use blocker limited to issues where a feature is broken (i.e. does not work, than a visibility/usabilty issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd closed issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653849107
A release blocker is an issue that must be fixed prior to a release. therefore blocker is the correct category.
Requiring the operator to hide the feature is not acceptable. the kubernetes plugin tab is only visible when the kubernetes plugin is enabled. The same should be true for the backup plugin. The operator should not have to fix inadequacies in ACS code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653832217
With @davidjumani
- Remove the view backup and vmsnapshot button via config::related for compute.js
- Instead add tabs to the VM instance/detail component to show/hide both backup and vm snapshots (similar to the volumes, nics etc tabs) depending on user-role access and availability of feature
@PaulAngus Lowering severity to Critical, we'll fix the issue for 1.0/GA but let's use blocker limited to issues where a feature is broken (i.e. does not work, than a visibility/usabilty issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-653869588
@PaulAngus I've already said show/hide "depending on user-role access" and "availability of feature" so why is that unacceptable? Why is this a release blocker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] PaulAngus commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-654765919
Viewed PR on-screen with DJ - fix LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on issue #487: [BUG] Backup tab is shown when Backup Framework is not enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #487:
URL: https://github.com/apache/cloudstack-primate/issues/487#issuecomment-654106248
Legacy UI also show the backups view and offering even when the feature is disabled globally and for all zones
Using http://docs.cloudstack.apache.org/en/latest/adminguide/backup_and_recovery.html as a reference, if the feature is not globally enabled (backup.framework.enabled) then it must not be considered enabled; therefore the feature is considered enabled for a zone when it's globally enabled and enabled for a zone https://github.com/apache/cloudstack/pull/4202
This will fix exporting the APIs, if feature is disabled it won't export APIs and clients such as cmk, Primate won't show APIs or views.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org