You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/12/05 18:13:00 UTC

[jira] [Work logged] (KNOX-3071) Batch list-alias and new create-list-aliases KnoxCLI commands

     [ https://issues.apache.org/jira/browse/KNOX-3071?focusedWorklogId=946920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-946920 ]

ASF GitHub Bot logged work on KNOX-3071:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/24 18:12
            Start Date: 05/Dec/24 18:12
    Worklog Time Spent: 10m 
      Work Description: pzampino commented on code in PR #940:
URL: https://github.com/apache/knox/pull/940#discussion_r1871878393


##########
gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java:
##########
@@ -275,6 +277,12 @@ private int init(String[] args) throws IOException {
           printKnoxShellUsage();
           return -1;
         }
+      } else if (args[i].equals("create-list-aliases")) {

Review Comment:
   If the new functionality can be added as an option(s) to the existing command without changing the previous behavior of the existing command (without those options), then I think I would prefer this over an entirely separate command. Ultimately, we're just creating aliases.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 946920)
    Time Spent: 1h  (was: 50m)

> Batch list-alias and new create-list-aliases KnoxCLI commands
> -------------------------------------------------------------
>
>                 Key: KNOX-3071
>                 URL: https://issues.apache.org/jira/browse/KNOX-3071
>             Project: Apache Knox
>          Issue Type: New Feature
>          Components: KnoxCLI
>    Affects Versions: 2.1.0
>            Reporter: Tamás Hanicz
>            Assignee: Tamás Hanicz
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> New feature for list-alias KnoxCLI command. The user should be able to provide multiple clusters concatenated by ',' and list the aliases for all of them. 
> list-alias --cluster cluster1,cluster2,clusterN
> New create-list-aliases command that creates aliases on multiple clusters and list them at the end.
> create-list-aliases --alias alias1 --value value1 --cluster cluster1 --alias alias2 --value value2 --cluster2 --alias aliasN --value valueN --cluster clusterN
> When there is a --cluster args every alias before it will be added to that cluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)