You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sunpe (via GitHub)" <gi...@apache.org> on 2023/04/16 06:31:17 UTC
[GitHub] [arrow] sunpe opened a new pull request, #35159: GH-35133:: fix for `math.MaxUint32 overflows int` error in 32-bit arch
sunpe opened a new pull request, #35159:
URL: https://github.com/apache/arrow/pull/35159
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
When compiling on i386 arch, an error like `math.MaxUint32 (untyped int constant 4294967295) overflows int` will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast `int` to `unint` to avoid this error.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35159: GH-35133: [Go] fix for `math.MaxUint32 overflows int` error in 32-bit arch
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35159:
URL: https://github.com/apache/arrow/pull/35159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35159: GH-35133: [Go] fix for `math.MaxUint32 overflows int` error in 32-bit arch
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35159:
URL: https://github.com/apache/arrow/pull/35159#issuecomment-1514078661
Benchmark runs are scheduled for baseline = 5605cf5ddfeed71becef5d0020c1288eff2d98bc and contender = becfaf31b31146031050d023216807d116b9cbcd. becfaf31b31146031050d023216807d116b9cbcd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8cd319b8259a44b69d276a8eb02d6e56...9b4e23f1f42348bb8d70e4a79f70cb02/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/aa3a842988df4f54a3e6d066a4b38cee...aea45a8aaf8245c2aa924ae57ff93cd7/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3690dddafea0472ca58cc1cab8ac5001...a237d65b1fa843e9bc8c6fd96f40d803/)
[Finished :arrow_down:0.34% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6c940dce0875457297989f4d8a103021...d779817151064a98bf925e4216f02dc9/)
Buildkite builds:
[Finished] [`becfaf31` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2733)
[Failed] [`becfaf31` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2767)
[Finished] [`becfaf31` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2731)
[Finished] [`becfaf31` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2758)
[Finished] [`5605cf5d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2732)
[Failed] [`5605cf5d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2766)
[Finished] [`5605cf5d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2730)
[Finished] [`5605cf5d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2757)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35159: GH-35133:: fix for `math.MaxUint32 overflows int` error in 32-bit arch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35159:
URL: https://github.com/apache/arrow/pull/35159#issuecomment-1510111448
* Closes: #35133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org