You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/03 13:39:41 UTC

[GitHub] [systemds] ywcb00 edited a comment on pull request #1218: [SYSTEMDS-2922] Federated Fused Codegen Operator - Rowwise

ywcb00 edited a comment on pull request #1218:
URL: https://github.com/apache/systemds/pull/1218#issuecomment-831265326


   Thank you for the feedback @Baunsgaard 
   I changed the sparsity to 0.1 and verified that no testcase generates an empty matrix. In addition to that, I've commented out some testcases which would test equal or very similar branches like other testcases to avoid redundant testing and further reduce the test time.
   I added some testcases for column paritioned federated data inside rowwise templates to verify that the matrices get pulled to the driver where the local operation gets executed (because column paritioned federated data is not supported by the federated rowwise spoof instruction itself).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org