You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/10 16:28:03 UTC

[GitHub] [pulsar] david-streamlio opened a new pull request #6937: Issue-6931 LocalRunner

david-streamlio opened a new pull request #6937:
URL: https://github.com/apache/pulsar/pull/6937


   <!--
   ### Contribution Checklist
   Fixes #6931 
   ### Motivation
   
   LocalRunner fails to launch local instances of Functions due to a "silent" NPE. This patch fixes that issue by providing a default value.
   
   ### Modifications
   
   Removed default value assignment from the Lombok annotated `FunctionConfig` class and added logic to set the default value inside the `FunctionConfigUtils.inferMissingArguments()` method where all the other default values get assigned.
   
   ### Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   ### Does this pull request potentially affect one of the following parts:
   
   NO
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no) 
   NO
     
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #6937: Issue-6931 LocalRunner

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6937:
URL: https://github.com/apache/pulsar/pull/6937#issuecomment-628470676


   @david-streamlio Can you update the description of this pull request? So other reviewers know what exactly you are trying to fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #6937: Issue-6931 LocalRunner

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6937:
URL: https://github.com/apache/pulsar/pull/6937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org