[GitHub] kovasb commented on issue #11205: Clojure Contrib Package

[GitBox <gi...@apache.org>]

kovasb commented on issue #11205: Clojure Contrib Package
URL: https://github.com/apache/incubator-mxnet/pull/11205#issuecomment-397467009
 
 
   Thanks for this contribution!
   
   In terms of code quality this looks very good, getting a lot done in a straightforward manner. People should feel good shipping this if/when test coverage is satisfactory.
   
   My only code question is: Where do the corner cases tend to lie? Whats the most complicated part where bugs might be lurking?
   
   Some higher level questions:
   
   - What is the debug experience like? It seems like errors can come from 3 places (mxnet core, scala, or clojure), is this a problem in practice? Can users track down what they did wrong?
   
   - What does maintenance look like? As MXNet & Scala API evolve, how much work does this codebase need to do to keep up? What changes are picked up automatically via introspection, vs requiring changing the codebase?
   
   - How do people learn to use the thing? Is it easy to go between the clojure functions and existing MXNet docs/tutorials? How is the documentation going to work long term?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services