You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/02 16:50:14 UTC

[GitHub] [incubator-pinot] xiaohui-sun commented on issue #4053: [TE] Speed up minute level detection

xiaohui-sun commented on issue #4053: [TE] Speed up minute level detection
URL: https://github.com/apache/incubator-pinot/pull/4053#issuecomment-479090604
 
 
   > I do not see any code removing pre-cache as mentioned in the description!
   
   This part
           // pre cache the time series for the whole detection time period instead of fetching for each window	
           if (this.cachingPeriodLookback >= 0) {	
             MetricSlice cacheSlice =	
                 MetricSlice.from(this.metricEntity.getId(), startTime - cachingPeriodLookback, endTime,	
                     this.metricEntity.getFilters(), toTimeGranularity(this.bucketPeriod));	
             this.provider.fetchTimeseries(Collections.singleton(cacheSlice));	
           }	

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org