You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/05/23 03:02:50 UTC

Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-11154
    https://issues.apache.org/jira/browse/AMBARI-11154


Repository: ambari


Description
-------

Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.

- STORM Configuration Changes
-- {{nimbus.host --> nimbus.seeds}}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 

Diff: https://reviews.apache.org/r/34622/diff/


Testing
-------

Storm Upgrade from HDP 2.2 to HDP 2.3


Thanks,

Jonathan Hurley


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On May 22, 2015, 9:23 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java, lines 377-378
> > <https://reviews.apache.org/r/34622/diff/1/?file=970179#file970179line377>
> >
> >     Should Copy and Move should also quote the value?

Yeah, I guess we should be consistent here. I really have no preference one way or another. But since we have double here, I'll change the others.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/#review85043
-----------------------------------------------------------


On May 22, 2015, 9:20 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34622/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 9:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11154
>     https://issues.apache.org/jira/browse/AMBARI-11154
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.
> 
> - STORM Configuration Changes
> -- {{nimbus.host --> nimbus.seeds}}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 
> 
> Diff: https://reviews.apache.org/r/34622/diff/
> 
> 
> Testing
> -------
> 
> Storm Upgrade from HDP 2.2 to HDP 2.3
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/#review85043
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
<https://reviews.apache.org/r/34622/#comment136515>

    Should Copy and Move should also quote the value?


- Nate Cole


On May 22, 2015, 9:20 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34622/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 9:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11154
>     https://issues.apache.org/jira/browse/AMBARI-11154
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.
> 
> - STORM Configuration Changes
> -- {{nimbus.host --> nimbus.seeds}}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 
> 
> Diff: https://reviews.apache.org/r/34622/diff/
> 
> 
> Testing
> -------
> 
> Storm Upgrade from HDP 2.2 to HDP 2.3
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/
-----------------------------------------------------------

(Updated May 22, 2015, 9:49 p.m.)


Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-11154
    https://issues.apache.org/jira/browse/AMBARI-11154


Repository: ambari


Description
-------

Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.

- STORM Configuration Changes
-- {{nimbus.host --> nimbus.seeds}}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 05aa89f 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 

Diff: https://reviews.apache.org/r/34622/diff/


Testing
-------

Storm Upgrade from HDP 2.2 to HDP 2.3


Thanks,

Jonathan Hurley


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/
-----------------------------------------------------------

(Updated May 22, 2015, 9:20 p.m.)


Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-11154
    https://issues.apache.org/jira/browse/AMBARI-11154


Repository: ambari


Description
-------

Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.

- STORM Configuration Changes
-- {{nimbus.host --> nimbus.seeds}}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
  ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
  ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 

Diff: https://reviews.apache.org/r/34622/diff/


Testing
-------

Storm Upgrade from HDP 2.2 to HDP 2.3


Thanks,

Jonathan Hurley


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On May 22, 2015, 9:10 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py, line 106
> > <https://reviews.apache.org/r/34622/diff/1/?file=970190#file970190line106>
> >
> >     "== 0" should be outside of cmp.

Geez - good eye! Luckily this is a safety condition, so it doesn't affect the testing.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/#review85041
-----------------------------------------------------------


On May 22, 2015, 9:02 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34622/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 9:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11154
>     https://issues.apache.org/jira/browse/AMBARI-11154
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.
> 
> - STORM Configuration Changes
> -- {{nimbus.host --> nimbus.seeds}}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 
> 
> Diff: https://reviews.apache.org/r/34622/diff/
> 
> 
> Testing
> -------
> 
> Storm Upgrade from HDP 2.2 to HDP 2.3
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 34622: Storm Upgrade Pack For HDP-2.2 to HDP-2.3

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34622/#review85041
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
<https://reviews.apache.org/r/34622/#comment136512>

    "== 0" should be outside of cmp.



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34622/#comment136511>

    Cool



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34622/#comment136513>

    Wow, this is getting really advanced.


- Alejandro Fernandez


On May 23, 2015, 1:02 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34622/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 1:02 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11154
>     https://issues.apache.org/jira/browse/AMBARI-11154
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Storm needs to be brought down entirely before any components are upgraded. In addition to this, we have to clean our local and remote directories to prevent bad bits from the old HDP 2.2 stack.
> 
> - STORM Configuration Changes
> -- {{nimbus.host --> nimbus.seeds}}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 03b3648 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6c254e8 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java 69a03f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java f5a77c5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java fe933cc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java fbd837c 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 66612bd 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml 2c7bbc4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 66b46c8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py 313bb17 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 59ec77c 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 901aecc 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 99397ac 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py bdb03df 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py bde533f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml 1aef735 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 6d50008 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml 4600a14 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml 33567c8 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java 66efea1 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java ca1a5a0 
> 
> Diff: https://reviews.apache.org/r/34622/diff/
> 
> 
> Testing
> -------
> 
> Storm Upgrade from HDP 2.2 to HDP 2.3
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>