[GitHub] [kafka] vvcephei commented on a change in pull request #11120: Add support for infinite endpoints for range queries

[GitBox <gi...@apache.org>]

vvcephei commented on a change in pull request #11120:
URL: https://github.com/apache/kafka/pull/11120#discussion_r678508676



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java
##########
@@ -65,9 +66,10 @@
      * Order is not guaranteed as bytes lexicographical ordering might not represent key order.
      *
      * @param from The first key that could be in the range, where iteration ends.
+     *             A null value indicates that the range ends with the first element in the store.
      * @param to   The last key that could be in the range, where iteration starts from.
+     *             A null value indicates a starting position from the last element in the store.

Review comment:
       It looks like these are backwards. If I understand this method signature, even though iteration is reversed, the "from" key is still the lower bound, and the "to" key is the upper.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org