You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/04/28 05:55:02 UTC

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4612: [Hotfix][JDBC Sink]Fix the relation of support_upsert_by_query_primary_key_exist and pri…

hailin0 commented on code in PR #4612:
URL: https://github.com/apache/incubator-seatunnel/pull/4612#discussion_r1179957288


##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkFactory.java:
##########
@@ -62,28 +50,6 @@ public String factoryIdentifier() {
         return "Jdbc";
     }
 
-    @Override
-    public TableSink createSink(TableFactoryContext context) {

Review Comment:
   why delete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org