You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/12/28 21:16:15 UTC

[commons-codec] branch master updated: Use Arrays.copyOf() and copyOfRange()

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new 2a2b04f8 Use Arrays.copyOf() and copyOfRange()
2a2b04f8 is described below

commit 2a2b04f8a7729297fc665cb1929f59a0b614f743
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Dec 28 16:16:11 2022 -0500

    Use Arrays.copyOf() and copyOfRange()
---
 src/main/java/org/apache/commons/codec/binary/BaseNCodec.java        | 3 +--
 src/main/java/org/apache/commons/codec/cli/Digest.java               | 3 +--
 src/main/java/org/apache/commons/codec/language/ColognePhonetic.java | 5 ++---
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java b/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
index 1e895951..996024e1 100644
--- a/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
+++ b/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
@@ -280,8 +280,7 @@ public abstract class BaseNCodec implements BinaryEncoder, BinaryDecoder {
             newCapacity = createPositiveCapacity(minCapacity);
         }
 
-        final byte[] b = new byte[newCapacity];
-        System.arraycopy(context.buffer, 0, b, 0, context.buffer.length);
+        final byte[] b = Arrays.copyOf(context.buffer, newCapacity);
         context.buffer = b;
         return b;
     }
diff --git a/src/main/java/org/apache/commons/codec/cli/Digest.java b/src/main/java/org/apache/commons/codec/cli/Digest.java
index 98150346..b809039e 100644
--- a/src/main/java/org/apache/commons/codec/cli/Digest.java
+++ b/src/main/java/org/apache/commons/codec/cli/Digest.java
@@ -71,8 +71,7 @@ public class Digest {
         if (argsLength <= 1) {
             inputs = null;
         } else {
-            inputs = new String[argsLength - 1];
-            System.arraycopy(args, 1, inputs, 0, inputs.length);
+            inputs = Arrays.copyOfRange(args, 1, argsLength);
         }
     }
 
diff --git a/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java b/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
index fcbd7e4b..a1e43d09 100644
--- a/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
+++ b/src/main/java/org/apache/commons/codec/language/ColognePhonetic.java
@@ -17,6 +17,7 @@
 
 package org.apache.commons.codec.language;
 
+import java.util.Arrays;
 import java.util.Locale;
 
 import org.apache.commons.codec.EncoderException;
@@ -258,9 +259,7 @@ public class ColognePhonetic implements StringEncoder {
 
         @Override
         protected char[] copyData(final int start, final int length) {
-            final char[] newData = new char[length];
-            System.arraycopy(data, start, newData, 0, length);
-            return newData;
+            return Arrays.copyOfRange(data, start, length);
         }
     }