You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "harshit2283 (via GitHub)" <gi...@apache.org> on 2024/07/10 08:58:07 UTC

[PR] fix(websocket): add error handling [superset]

harshit2283 opened a new pull request, #29538:
URL: https://github.com/apache/superset/pull/29538

   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Adding Error handling in websocket to avoid crashing whole service due to a faulty socket etc
   
   Certain Browsers (i.e Safari) don't play nicely with WS Protocol, they can end up crashing the whole service. [ref](https://github.com/websockets/ws/issues/1354#issuecomment-1288007531)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(websocket): add error handling [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #29538:
URL: https://github.com/apache/superset/pull/29538#issuecomment-2220465305

   @harshit2283 it seems there's a linting error. Can you fix it so we can get this merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(websocket): add error handling [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #29538:
URL: https://github.com/apache/superset/pull/29538#issuecomment-2220835318

   btw @harshit2283 as you appear to be using GAQ with websockets, it would be valuable to get your feedback on a recent proposal to simplify the GAQ architecture: #29515


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(websocket): add error handling [superset]

Posted by "harshit2283 (via GitHub)" <gi...@apache.org>.
harshit2283 commented on PR #29538:
URL: https://github.com/apache/superset/pull/29538#issuecomment-2221983172

   @villebro Sure, I will check it out. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(websocket): add error handling [superset]

Posted by "harshit2283 (via GitHub)" <gi...@apache.org>.
harshit2283 commented on PR #29538:
URL: https://github.com/apache/superset/pull/29538#issuecomment-2220485417

   > @harshit2283 it seems there's a linting error. Can you fix it so we can get this merged?
   
   Have fixed it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(websocket): add error handling [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #29538:
URL: https://github.com/apache/superset/pull/29538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org