You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by benoyantony <gi...@git.apache.org> on 2017/04/05 03:54:57 UTC
[GitHub] zeppelin pull request #2223: [ZEPPELIN-2355] Livy cancel enhancements
GitHub user benoyantony opened a pull request:
https://github.com/apache/zeppelin/pull/2223
[ZEPPELIN-2355] Livy cancel enhancements
### What is this PR for?
The Cancel functionality for the Livy interpreter has a couple of issues. One issue is because a variable is not published correctly. Second issue is observed when there is a delay in launching the application. Any cancel before application launch is ignored. The third issue is that Cancel is not correctly implemented for SparkSQLInterpreter.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2355
### How should this be tested?
The test cases are modified to test the changes.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benoyantony/zeppelin livy-cancel-enhancement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2223
----
commit 8673acfd5da76e547b986fb9dcfdb74fc3c379cf
Author: Benoy Antony <be...@apache.org>
Date: 2017-04-05T03:27:30Z
ZEPPELIN-2355 Fix race conditions while cancelling a paragraph
commit 4f1f243b2b8e16860b25dd59f31924fb2c16c8c3
Author: Benoy Antony <be...@apache.org>
Date: 2017-04-05T03:36:16Z
remove unrelated changes in imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2223
A testcase errored out and it seems to be unrelated.
ParagraphActionsIT.testRunOnSelectionChange
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2223
@benoyantony Thanks for the contribution, just left some comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2223
@benoyantony You can call cancel in a separate thread, the same as testSparkInterpreterRDD, let me know if you have any other questions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2223
@zjffdu , Will try to add the unit test for cancellation in LivySparkSQLInterpreter. Any suggestion on how to simulate a sleep in SQL ?
Also, where are the other comments ? Sorry, I am not very familiar with the github code reviews. It may be very obvious.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2223
Thanks @zjffdu for reviewing and committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by benoyantony <gi...@git.apache.org>.
Github user benoyantony commented on the issue:
https://github.com/apache/zeppelin/pull/2223
@zjffdu , Could you please review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2223
Thanks @benoyantony will merge it if no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---