You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/06 23:08:25 UTC
[GitHub] [incubator-tvm] jiangzoi opened a new pull request #5999: fix typos in comments and relay tutorial
jiangzoi opened a new pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999
@zhiics
Hi Zhi,
Please review my pull request when you have time. It is related to typo fix in code comments and tutorial.
Thank you so much!
Zheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655749564
The flakiness is fixed this morning. Could you push an empty commit to re-trigger the CI?
```
git commit --allow-empty -m "retrigger"
git push
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jiangzoi commented on a change in pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
jiangzoi commented on a change in pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#discussion_r450549419
##########
File path: include/tvm/runtime/object.h
##########
@@ -1,877 +0,0 @@
-/*
Review comment:
It is deleted by mistake. I will update the PR soon. Thank you for your help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655899354
Thanks @jiangzoi @ymwangg @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jiangzoi commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
jiangzoi commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655745333
> flaky
Thanks Junru for help, should I open a new pull request to see whether it could be fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jiangzoi commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
jiangzoi commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655948187
Thank you for your help for my first PR! @zhiics @ymwangg @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655033499
Thanks for fixing. Could you retrigger the CI? The error should be irrelevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#issuecomment-655194523
Looks like a flaky test. Saw it several times this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics merged pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
zhiics merged pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] ymwangg commented on a change in pull request #5999: fix typos in comments and relay tutorial
Posted by GitBox <gi...@apache.org>.
ymwangg commented on a change in pull request #5999:
URL: https://github.com/apache/incubator-tvm/pull/5999#discussion_r450545848
##########
File path: include/tvm/runtime/object.h
##########
@@ -1,877 +0,0 @@
-/*
Review comment:
Why this file is deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org