You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/25 14:29:20 UTC
[GitHub] codecov-io commented on issue #465: SCB-981 Can not remove the
microservice and instance properties
codecov-io commented on issue #465: SCB-981 Can not remove the microservice and instance properties
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/465#issuecomment-433073581
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=h1) Report
> Merging [#465](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3ddb255953e70a35ec511aecb064f18c50236f81?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #465 +/- ##
=========================================
- Coverage 60.2% 60.2% -0.01%
=========================================
Files 156 156
Lines 13412 13410 -2
=========================================
- Hits 8075 8073 -2
+ Misses 4763 4760 -3
- Partials 574 577 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <ø> (ø)` | :arrow_up: |
| [server/service/microservice\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlX3ZhbGlkYXRvci5nbw==) | `100% <ø> (ø)` | :arrow_up: |
| [pkg/task/executor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL3Rhc2svZXhlY3V0b3IuZ28=) | `72% <0%> (-4%)` | :arrow_down: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (-3.85%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: |
| [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.26% <0%> (-0.6%)` | :arrow_down: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: |
| [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `72.44% <0%> (+0.98%)` | :arrow_up: |
| [server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==) | `69.56% <0%> (+4.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=footer). Last update [3ddb255...a37deab](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services