[jira] [Commented] (TWILL-237) Twill is using hdfs HAUtil api that is nont-compatible with hadoop 2.8

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TWILL-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113139#comment-16113139 ] 

ASF GitHub Bot commented on TWILL-237:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/55#discussion_r131207866
  
    --- Diff: twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java ---
    @@ -162,7 +163,8 @@ public URI toURI() {
         // append "port" to the path URI, while the DistributedFileSystem always use the cluster logical
         // name, which doesn't allow having port in it.
         URI uri = path.toUri();
    -    if (HAUtil.isLogicalUri(locationFactory.getConfiguration(), uri)) {
    +
    +    if (FileContextLocationUtil.useLogicalUri(locationFactory.getConfiguration(), uri)) {
    --- End diff --
    
    That make sense.


> Twill is using hdfs HAUtil api that is nont-compatible with hadoop 2.8
> ----------------------------------------------------------------------
>
>                 Key: TWILL-237
>                 URL: https://issues.apache.org/jira/browse/TWILL-237
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: yarn
>            Reporter: Yuliya Feldman
>            Assignee: Yuliya Feldman
>
> Twill is using hdfs.HAUtil apis that are suppose to be hdfs private and subsequently signature of isLogicalURI was changed (actually name was changed) in hadoop version 2.8
> Will post a patch for now to support both old and new names, but I think eventually references to private hdfs interfaces/classes should be removed from twill



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)