You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 09:30:20 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

iamayushdas opened a new pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Refactor
   
   **What changes will this PR take into?**
   
   Refactor Testcase for Frontend.
   
   **Related issues**
   
   related issue #1774 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun merged pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun merged pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835243174


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 7175b66722f7ed54342c4db23c5c8408520d7e4c
   
   https://deploy-preview-1874--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835243174


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit fdd841bc75bee6df48736d468380b7deb59a133c
   
   https://deploy-preview-1874--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835243174


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 7175b66722f7ed54342c4db23c5c8408520d7e4c
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60965a2118fd3e000704585a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835243174


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit fdd841bc75bee6df48736d468380b7deb59a133c
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609aa4005f965c00070d7b69


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835254553


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1874](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7175b66) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1874      +/-   ##
   ==========================================
   + Coverage   72.10%   72.17%   +0.06%     
   ==========================================
     Files         125      125              
     Lines        2947     2947              
     Branches      711      711              
   ==========================================
   + Hits         2125     2127       +2     
   + Misses        822      820       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.17% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...7175b66](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1874: chore: refactored test create-service-with-not-select-upstream.spec.js

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1874:
URL: https://github.com/apache/apisix-dashboard/pull/1874#issuecomment-835254553


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1874](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fdd841b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **decrease** coverage by `3.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1874      +/-   ##
   ==========================================
   - Coverage   72.10%   68.91%   -3.20%     
   ==========================================
     Files         125      122       -3     
     Lines        2947     3111     +164     
     Branches      711      745      +34     
   ==========================================
   + Hits         2125     2144      +19     
   - Misses        822      967     +145     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.91% <ø> (-3.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `84.55% <0.00%> (-6.44%)` | :arrow_down: |
   | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `51.85% <0.00%> (-1.72%)` | :arrow_down: |
   | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <0.00%> (ø)` | |
   | [...rc/components/PluginOrchestration/customConfig.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY3VzdG9tQ29uZmlnLnRzeA==) | | |
   | [...components/PluginOrchestration/components/Page.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9QYWdlLnRzeA==) | | |
   | [web/src/components/PluginOrchestration/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vaW5kZXgudHN4) | | |
   | [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | |
   | [...nts/PluginOrchestration/components/SidebarItem.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9TaWRlYmFySXRlbS50c3g=) | | |
   | [...eb/src/components/PluginOrchestration/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29uc3RhbnRzLnRz) | | |
   | [web/src/components/PluginOrchestration/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vc2VydmljZS50cw==) | | |
   | ... and [10 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1874/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...fdd841b](https://codecov.io/gh/apache/apisix-dashboard/pull/1874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org