[PATCH] HttpClient HEAD dependencies

[ol...@bluewin.ch]

Hi there,

In the past HttpClient project has been often called Gump unfriendly. Having
a little bit of spare time on my hands and intent on changing this perception
I would like to consult with you, guys, before we introduce a new dependency
for the development (post 2.0) version of HttpClient and upset quite a few
folks by causing Gump breakage. As of next version HttpClient will be dependent
on Commons-Codec. I am about to commit a patch that uses Commons-Codec classes
to the CVS HEAD. Thus I am kindly asking you to update Gump project definitions
in order to avoid unnecessary Gump nightly builds breakage and to prevent
a new wave of condemnations for Gump unfriendliness.

I would also like to have log4j dependency removed (for both 2.0 and HEAD),
as in fact HttpClient no longer requires this library. 

I attach a patch which _may_ already provide necessary changes to the project
definitions. However, being fundamentally Gump illiterate I am not sure if
the patch is sufficient or correct at all.

If there's anything else you would like us to do to make HttpClient play
with Gump better, just let me know

Cheers

Oleg

Re: [PATCH] HttpClient HEAD dependencies

["Adam R. B. Jack" <aj...@trysybase.com>]

> Chris & Adam,
>
> I can commit it myself no problem, however,
> I think it will take an experienced Gumper only a fraction of time of what
> it may take me to get everything set up and verified on my development
workstation.
> I'd really appreciate if you could spare me this trouble.

I am of the (personal) opinion that users ought not be expected to run Gump
(gen.sh) to contribute metadata. We are always saying it is so hard to get
the community to manage their own metadata, and this is a barrier that I'd
like to see reduced/removed. I'd like to see us (when we get resources
squared away) have some things like automated (hourly or frequent) 'metadata
validation runs' or on demand validations (a web app) so users don't have to
install Gump.

For this time, I'll happily do it manually for Oleg since his changes (and
first glance) look painless.

regards,

Adam

P.S. I've been out of it (still am w/ jet lag/cold & a young un's returning
schedule) and haven't caught up w/ infra@ and such. Has there been any
progress on a gump.apache.org? Is there one coming? Is there an ETA? [My
gump.try was a failure (on old hardware) 'cos it push the VMWare too hard &
things broke. I'll try again (on new hardware) in a couple of weeks, or
less.]

Re: [PATCH] HttpClient HEAD dependencies

[ol...@bluewin.ch]

>-- Original Message --
>Reply-To: "Gump code and data" <gu...@jakarta.apache.org>
>From: Christopher Lenz <cm...@gmx.de>
>Subject: Re: [PATCH] HttpClient HEAD dependencies
>Date: Tue, 6 Jan 2004 15:04:08 +0100
>To: "Gump code and data" <gu...@jakarta.apache.org>
>
>
>Hi Oleg,
>
>either you forgot to attach the patch, or it was stripped. Can you try 
>again?
>

Chris & Adam,

I completely forgot that the webmail client I am using does not play nicely
with the Apache's mailing list manager. The patch is actually trivial so
I am posting it inline below. I can commit it myself no problem, however,
I think it will take an experienced Gumper only a fraction of time of what
it may take me to get everything set up and verified on my development workstation.
I'd really appreciate if you could spare me this trouble.



Index: commons-httpclient-2.0-branch.xml
===================================================================
RCS file: /home/cvspublic/jakarta-gump/project/commons-httpclient-2.0-branch.xml,v
retrieving revision 1.2
diff -u -r1.2 commons-httpclient-2.0-branch.xml
--- commons-httpclient-2.0-branch.xml	29 Jul 2003 12:51:39 -0000	1.2
+++ commons-httpclient-2.0-branch.xml	6 Jan 2004 14:29:47 -0000
@@ -15,7 +15,6 @@
     <depend project="ant" inherit="runtime"/>
     <depend project="xml-xerces"/>
     <option project="jsse"/>
-    <depend project="jakarta-log4j"/>
     <depend project="commons-logging" runtime="true"/>
     <work nested="target/classes"/>
     <home nested="dist"/>
Index: jakarta-commons.xml
===================================================================
RCS file: /home/cvspublic/jakarta-gump/project/jakarta-commons.xml,v
retrieving revision 1.117
diff -u -r1.117 jakarta-commons.xml
--- jakarta-commons.xml	27 Dec 2003 03:44:02 -0000	1.117
+++ jakarta-commons.xml	6 Jan 2004 14:29:47 -0000
@@ -244,7 +244,7 @@
     <depend project="ant" inherit="runtime"/>
     <depend project="xml-xerces"/>
     <option project="jsse"/>
-    <depend project="jakarta-log4j"/>
+    <depend project="commons-codec" runtime="true"/>
     <depend project="commons-logging" runtime="true"/>
     <!-- included in JDK 1.4 depend project="jce"/-->
     <work nested="httpclient/target/classes"/>

Re: [PATCH] HttpClient HEAD dependencies

[Christopher Lenz <cm...@gmx.de>]

Hi Oleg,

either you forgot to attach the patch, or it was stripped. Can you try 
again?

FYI, every Apache committer has karma on jakarta-gump, so you can also 
commit the changes yourself. Just make sure that you can run a 
gen.sh/bat [1] without having it spit out errors in the first couple of 
phases. That will verify that there's nothing wrong syntactically etc.

[1] http://jakarta.apache.org/gump/traditional/usage.html

--
Christopher Lenz
/=/ cmlenz at gmx.de

Am 06.01.2004 um 13:50 schrieb olegk@bluewin.ch:

> Hi there,
>
> In the past HttpClient project has been often called Gump unfriendly. 
> Having
> a little bit of spare time on my hands and intent on changing this 
> perception
> I would like to consult with you, guys, before we introduce a new 
> dependency
> for the development (post 2.0) version of HttpClient and upset quite a 
> few
> folks by causing Gump breakage. As of next version HttpClient will be 
> dependent
> on Commons-Codec. I am about to commit a patch that uses Commons-Codec 
> classes
> to the CVS HEAD. Thus I am kindly asking you to update Gump project 
> definitions
> in order to avoid unnecessary Gump nightly builds breakage and to 
> prevent
> a new wave of condemnations for Gump unfriendliness.
>
> I would also like to have log4j dependency removed (for both 2.0 and 
> HEAD),
> as in fact HttpClient no longer requires this library.
>
> I attach a patch which _may_ already provide necessary changes to the 
> project
> definitions. However, being fundamentally Gump illiterate I am not 
> sure if
> the patch is sufficient or correct at all.
>
> If there's anything else you would like us to do to make HttpClient 
> play
> with Gump better, just let me know
>
> Cheers
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: gump-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: gump-help@jakarta.apache.org

Re: [PATCH] HttpClient HEAD dependencies

["Adam R. B. Jack" <aj...@trysybase.com>]

Oleg wrote:

> In the past HttpClient project has been often called Gump unfriendly.
Having
a little bit of spare time on my hands and intent on changing this
perception

First, for the time that I said it, please let me clarify that 'breaking
interfaces in CVS HEAD without having two projects (old & new)' was seen as
Gump unfriendly ('cos it doesn't grant time/choice to other projects & break
them) not HttpClient per se. That said, others weren't so convinced that you
needed to do what I sugested (saying it was an optional nicety) & it only
bacame a big issue for me 'cos a third party project was stagnating and
didn't track your change. I understand that HttpClient needs to break
interfaces to clean up past design decisions, and appreciate you working
with the Gump folks to try to do this as painlessly as possible to the
community.

> I would like to consult with you, guys, before we introduce a new
dependency

Adding/Removing dependencies at any time (in CVS head or not) ought not
affect Gump [so long as the descriptor is change] nor other projects [so
long as the interface doesn't change]. As such, this isn't the same sized
problem for the community. Also, typically (if/when we see something start
failing to compile) we'll just update the descriptor accordingly. We
appreciate the heads up though.

> I attach a patch which _may_ already provide necessary changes to the
project
> definitions. However, being fundamentally Gump illiterate I am not sure if
> the patch is sufficient or correct at all.

Sorry, but for me the patch isn't showing. I don't understand it. I see a
paperclip, but can't get to an attachment. Maybe my mail tool thinks it is
protecting me from something, but I've tried turning all that off. Could you
try cut-n-paste for review? Also, can you change the descriptor yourself
inside gump CVS?

> If there's anything else you would like us to do to make HttpClient play
> with Gump better, just let me know

Thanks, very much appreciated.

regards

Adam