You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/16 08:13:15 UTC
[jira] Created: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
[classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
----------------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-1204
URL: http://issues.apache.org/jira/browse/HARMONY-1204
Project: Harmony
Issue Type: Test
Components: Classlib
Reporter: Andrew Zhang
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
try {
ds = new java.net.DatagramSocket();
InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
int portNumber = Support_PortManager.getNextPort();
ds.connect(inetAddress, portNumber);
assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
inetAddress));
assertTrue("Incorrect Port", ds.getPort() == portNumber);
ds.disconnect();
} catch (Exception e) {
fail("Exception during test : " + e.getMessage());
}
I'll upload a patch to fix this problem soon.
Thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1204?page=all ]
Andrew Zhang updated HARMONY-1204:
----------------------------------
Attachment: Harmony-1204.diff
Hi,
Would you please try my patch? Additionally, the patch also fixes the same problem in test_disconnect.
Thanks!
Best regards,
Andrew
> [classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1204
> URL: http://issues.apache.org/jira/browse/HARMONY-1204
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: Harmony-1204.diff
>
>
> tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
> try {
> ds = new java.net.DatagramSocket();
> InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
> int portNumber = Support_PortManager.getNextPort();
> ds.connect(inetAddress, portNumber);
> assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
> inetAddress));
> assertTrue("Incorrect Port", ds.getPort() == portNumber);
> ds.disconnect();
> } catch (Exception e) {
> fail("Exception during test : " + e.getMessage());
> }
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1204?page=all ]
Paulex Yang closed HARMONY-1204.
--------------------------------
Verified by Andrew.
> [classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1204
> URL: http://issues.apache.org/jira/browse/HARMONY-1204
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1204.diff
>
>
> tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
> try {
> ds = new java.net.DatagramSocket();
> InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
> int portNumber = Support_PortManager.getNextPort();
> ds.connect(inetAddress, portNumber);
> assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
> inetAddress));
> assertTrue("Incorrect Port", ds.getPort() == portNumber);
> ds.disconnect();
> } catch (Exception e) {
> fail("Exception during test : " + e.getMessage());
> }
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1204?page=comments#action_12428610 ]
Andrew Zhang commented on HARMONY-1204:
---------------------------------------
Hi Paulex,
The fix looks fine, thanks!
Best regards,
Andrew
> [classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1204
> URL: http://issues.apache.org/jira/browse/HARMONY-1204
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1204.diff
>
>
> tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
> try {
> ds = new java.net.DatagramSocket();
> InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
> int portNumber = Support_PortManager.getNextPort();
> ds.connect(inetAddress, portNumber);
> assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
> inetAddress));
> assertTrue("Incorrect Port", ds.getPort() == portNumber);
> ds.disconnect();
> } catch (Exception e) {
> fail("Exception during test : " + e.getMessage());
> }
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1204?page=all ]
Paulex Yang resolved HARMONY-1204.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r432187, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1204
> URL: http://issues.apache.org/jira/browse/HARMONY-1204
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1204.diff
>
>
> tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
> try {
> ds = new java.net.DatagramSocket();
> InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
> int portNumber = Support_PortManager.getNextPort();
> ds.connect(inetAddress, portNumber);
> assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
> inetAddress));
> assertTrue("Incorrect Port", ds.getPort() == portNumber);
> ds.disconnect();
> } catch (Exception e) {
> fail("Exception during test : " + e.getMessage());
> }
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1204) [classlib][luni]
tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI()
is dependent on unnecessary external server.
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1204?page=all ]
Paulex Yang reassigned HARMONY-1204:
------------------------------------
Assignee: Paulex Yang
> [classlib][luni] tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-1204
> URL: http://issues.apache.org/jira/browse/HARMONY-1204
> Project: Harmony
> Issue Type: Test
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Attachments: Harmony-1204.diff
>
>
> tests.api.java.net.DatagramSocketTest.test_connectLjava_net_InetAddressI() is dependent on unnecessary external server.
> Consider following test code, which is unnecessarily dependent on Support_Configuration.HomeAddress. In fact, the test can be revised to connect to localhost.
> try {
> ds = new java.net.DatagramSocket();
> InetAddress inetAddress = InetAddress.getByName(Support_Configuration.HomeAddress);
> int portNumber = Support_PortManager.getNextPort();
> ds.connect(inetAddress, portNumber);
> assertTrue("Incorrect InetAddress", ds.getInetAddress().equals(
> inetAddress));
> assertTrue("Incorrect Port", ds.getPort() == portNumber);
> ds.disconnect();
> } catch (Exception e) {
> fail("Exception during test : " + e.getMessage());
> }
> I'll upload a patch to fix this problem soon.
> Thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira