You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/01 21:38:57 UTC

[GitHub] [geode] PurelyApplied opened pull request #2547: GEODE-5606: Remove CategoryWithParameterizedRunnerFactory et al.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [manual inspection required] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2547 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2547: GEODE-5606: Remove CategoryWithParameterizedRunnerFactory et al.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Fie, FIE I say!

I guess I'll back-burner this then, too.  Although it looks like the obfuscation of categories has been resolved natively by Gradle5.  So whichever of JUnit5 or Gradle5 is the easier / sooner upgrade, it looks like *then* this will be an okay cleanup.

[ Full content available at: https://github.com/apache/geode/pull/2547 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2547: GEODE-5606: Remove CategoryWithParameterizedRunnerFactory et al.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2547 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2547: GEODE-5606: Remove CategoryWithParameterizedRunnerFactory et al.

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Also @rhoughton-pivot .

[ Full content available at: https://github.com/apache/geode/pull/2547 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org