[GitHub] [spark] srowen commented on a change in pull request #29482: [SPARK-32662][MLLib] CountVectorizerModel: Remove requirement for minimum Vocab size

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #29482:
URL: https://github.com/apache/spark/pull/29482#discussion_r474101722



##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala
##########
@@ -241,7 +241,9 @@ class CountVectorizer @Since("1.5.0") (@Since("1.5.0") override val uid: String)
     }
     wordCounts.unpersist()
 
-    require(vocab.length > 0, "The vocabulary size should be > 0. Lower minDF as necessary.")
+    if (vocab.isEmpty) {
+      this.logWarning("The vocabulary size is empty. Alter minDF/maxDF as necessary.")

Review comment:
       Minor, but it's `minTF` (it was wrong before). Also we could suggest lowering minTF, or increasing maxDF, more specifically.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org