[GitHub] [iceberg] rdblue commented on a diff in pull request #7059: Flink: Bump to Flink 1.15.3

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #7059:
URL: https://github.com/apache/iceberg/pull/7059#discussion_r1136333567


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -69,16 +73,20 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
     List<String> equalityColumns =
         tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
 
-    return (DataStreamSinkProvider)

Review Comment:
   I agree with not chasing Flink patch releases if they require code changes. I'd love to make sure they compile and work, but I wouldn't spend time tracking down errors between patch versions for third-party projects. If code changes are required, then we should stop update to a new patch version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org