You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/15 21:07:03 UTC
[jira] [Commented] (OOZIE-821) Unit test to account for log
retrieval from multiple gzipped oozie.log files
[ https://issues.apache.org/jira/browse/OOZIE-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276109#comment-13276109 ]
jiraposter@reviews.apache.org commented on OOZIE-821:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4881/#review7902
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17212>
can we have a function foo(File, String) which will write the string to the file? this will increase readability
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17213>
can this just have only necessary info like 'debug', '_L19_' instead of a big string?..same comment for other places
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17214>
is this required if the next call is close()?
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java
<https://reviews.apache.org/r/4881/#comment17215>
did u mean 2012-03-24
- Virag
On 2012-04-26 00:15:30, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4881/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 00:15:30)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Oozie.log files can be gzipped by a log setting and then we work with hourly .gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed the log retrieval issue from multiple such gz files. I'm adding a unit test for checking this functionality.
bq.
bq.
bq. This addresses bug OOZIE-821.
bq. https://issues.apache.org/jira/browse/OOZIE-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1326832
bq.
bq. Diff: https://reviews.apache.org/r/4881/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> Unit test to account for log retrieval from multiple gzipped oozie.log files
> ----------------------------------------------------------------------------
>
> Key: OOZIE-821
> URL: https://issues.apache.org/jira/browse/OOZIE-821
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Priority: Minor
> Labels: oozie
> Fix For: 3.2.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Oozie.log files can be gzipped by a log setting and then we work with hourly gz log files. For a long running job spanning multiple hours, OOZIE-590 fixed the log retrieval issue from multiple such gz files. I'm adding a unit test for checking this functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira