You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/29 09:39:36 UTC

[GitHub] [spark] beliefer opened a new pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

beliefer opened a new pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745
 
 
   ### What changes were proposed in this pull request?
   1.Add version information to the configuration of `Streaming`.
   2.Update the docs of `Streaming`.
   
   I sorted out some information show below.
   
   Item name | Since version | JIRA ID | Commit ID | Note
   -- | -- | -- | -- | --
   spark.streaming.dynamicAllocation.enabled | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.testing | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.minExecutors | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.maxExecutors | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.scalingInterval | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.scalingUpRatio | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   spark.streaming.dynamicAllocation.scalingDownRatio | 3.0.0 | SPARK-26941 | cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd | 
   
   
   ### Why are the changes needed?
   Supplemental configuration version information.
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   Exists UT
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-593239905
 
 
   You can link multiple JIRAs in the PR title. Let's do it at single PR in batch if there are not so many instances to fix against single JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592927065
 
 
   **[Test build #119121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119121/testReport)** for PR 27745 at commit [`2003b0c`](https://github.com/apache/spark/commit/2003b0c5b890201d7716c21037c3e6f3545ea0cd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-593239682
 
 
   @beliefer, when there are not so many instances like this PR, let's do it with other PRs. I still think @maropu's concern is valid and it's better to do it in batch in general, rather then a small PR like this one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon edited a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-593239682
 
 
   @beliefer, when there are not so many instances like this PR, let's do it with other PRs. I still think @maropu's concern is valid and it's better to do it in batch in general, rather than a small PR like this one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016015
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_MIN_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.minExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The min executor number of streaming dynamic " +
         "allocation must be positive.")
       .createOptional
 
   private[spark] val STREAMING_DYN_ALLOCATION_MAX_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.maxExecutors")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592939509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-593238765
 
 
   Merged to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386015993
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016036
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_MIN_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.minExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The min executor number of streaming dynamic " +
         "allocation must be positive.")
       .createOptional
 
   private[spark] val STREAMING_DYN_ALLOCATION_MAX_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.maxExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The max executor number of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(Int.MaxValue)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_INTERVAL =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingInterval")
+      .version("3.0.0")
       .timeConf(TimeUnit.SECONDS)
       .checkValue(_ > 0, "The scaling interval of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(60)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_UP_RATIO =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingUpRatio")
+      .version("3.0.0")
       .doubleConf
       .checkValue(_ > 0, "The scaling up ratio of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(0.9)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_DOWN_RATIO =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingDownRatio")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-609306546
 
 
   Merged to branch-3.0 too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016017
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_MIN_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.minExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The min executor number of streaming dynamic " +
         "allocation must be positive.")
       .createOptional
 
   private[spark] val STREAMING_DYN_ALLOCATION_MAX_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.maxExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The max executor number of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(Int.MaxValue)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_INTERVAL =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingInterval")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592926460
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23863/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016035
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_MIN_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.minExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The min executor number of streaming dynamic " +
         "allocation must be positive.")
       .createOptional
 
   private[spark] val STREAMING_DYN_ALLOCATION_MAX_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.maxExecutors")
+      .version("3.0.0")
       .intConf
       .checkValue(_ > 0, "The max executor number of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(Int.MaxValue)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_INTERVAL =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingInterval")
+      .version("3.0.0")
       .timeConf(TimeUnit.SECONDS)
       .checkValue(_ > 0, "The scaling interval of streaming dynamic " +
         "allocation must be positive.")
       .createWithDefault(60)
 
   private[spark] val STREAMING_DYN_ALLOCATION_SCALING_UP_RATIO =
     ConfigBuilder("spark.streaming.dynamicAllocation.scalingUpRatio")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592939513
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119121/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592927065
 
 
   **[Test build #119121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119121/testReport)** for PR 27745 at commit [`2003b0c`](https://github.com/apache/spark/commit/2003b0c5b890201d7716c21037c3e6f3545ea0cd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016013
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_MIN_EXECUTORS =
     ConfigBuilder("spark.streaming.dynamicAllocation.minExecutors")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592926460
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23863/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592926459
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592939509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-593239905
 
 
   You can link multiple JIRAs in the PR title. Let's do it in single PR if there are not so many instances to fix against single JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#discussion_r386016011
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/Streaming.scala
 ##########
 @@ -23,44 +23,51 @@ private[spark] object Streaming {
 
   private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
     ConfigBuilder("spark.streaming.dynamicAllocation.enabled")
+      .version("3.0.0")
       .booleanConf
       .createWithDefault(false)
 
   private[spark] val STREAMING_DYN_ALLOCATION_TESTING =
     ConfigBuilder("spark.streaming.dynamicAllocation.testing")
+      .version("3.0.0")
 
 Review comment:
   SPARK-26941, commit ID: cad475dcc9376557f882859856286e858002389a#diff-335c3bbf4ca27cf65a6f850b1a7c89dd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592926459
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592939513
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119121/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27745: [SPARK-30912][CORE][DOC] Add version information to the configuration of Streaming.scala
URL: https://github.com/apache/spark/pull/27745#issuecomment-592939319
 
 
   **[Test build #119121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119121/testReport)** for PR 27745 at commit [`2003b0c`](https://github.com/apache/spark/commit/2003b0c5b890201d7716c21037c3e6f3545ea0cd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org