[jira] Commented: (PIG-1303) unable to set outgoing format for org.apache.pig.piggybank.evaluation.util.apachelogparser.DateExtractor

["hc busy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860103#action_12860103 ] 

hc busy commented on PIG-1303:
------------------------------

Okay, so, here's a thought:

I'm kind of stuck writing the initial/intermed/Final methods for an algebraic EvalFunc that has constructor parameters because I couldn't pass the parameters in.


A suggestion is to do this (without being incompatible with previous versions)

Alter EvalFunc's profile so that

{code}
public abstract class EvalFunc<T>  {

   protected handleChildConstructorParameters(Object... childConstructor){
      // by default do nothing.
   }

    public EvalFunc(Object... constructorParameters){
        handleChildConstructorParameters(constructorParameters);
        ... then do everything else it used to do.
    }
}
{code}


The reason why this is necessary is because I'll need to overrite handleChildConstructorParameters in my Algebraic EvalFunc to do some things before the rest of EvalFunc()'s constructor continues. This will help fix this date format problem for Algebraic evalfunc's.




> unable to set outgoing format for org.apache.pig.piggybank.evaluation.util.apachelogparser.DateExtractor
> --------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-1303
>                 URL: https://issues.apache.org/jira/browse/PIG-1303
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>         Environment: pig 0.6.0 on a fedora linux machine, jdk 1.6 u11
>            Reporter: Johannes Rußek
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: TypeCheckingVisitor.java.diff
>
>
> I'm unable to set the format of the outgoing date string in the constructor as it's supposed to work. 
> The only way i could change the format was to change the default in the java class and rebuild piggybank.
> Apparently this has something to do with the way pig instantiates DateExtractor, quoting a replier on the mailing list:
> David Vrensk said:
> I ran into the same problem a couple of weeks ago, and
> played around with the code inserting some print/log statements.  It turns
> out that the arguments are only used in the initial constructor calls, when
> the pig process is starting, but once pig reaches the point where it would
> use the udf, it creates new DateExtractors without passing the arguments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.