You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 22:04:11 UTC

[GitHub] [arrow] ovr commented on a change in pull request #9175: ARROW-11221: [Rust] DF Implement GROUP BY support for Float32/Float64

ovr commented on a change in pull request #9175:
URL: https://github.com/apache/arrow/pull/9175#discussion_r556125440



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -776,6 +785,14 @@ pub(crate) fn create_group_by_values(
     for i in 0..group_by_keys.len() {
         let col = &group_by_keys[i];
         match col.data_type() {
+            DataType::Float32 => {

Review comment:
       I've updated PR, forget about this place. Testing it with real DB example.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org