You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/05/26 03:11:54 UTC
[Bug 4367] New: SORBS tests seem to be wrong
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
Summary: SORBS tests seem to be wrong
Product: Spamassassin
Version: 3.0.3
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: thomasz@hostmaster.org
According to http://www.nl.sorbs.net/using.shtml they use
127.0.0.3 (not 127.0.0.5) for open socks proxies
127.0.0.4 (not 127.0.0.3) for misc proxies
127.0.0.5 (not 127.0.0.4) for open smtp relays
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
Bob@Menschel.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |trivial
OS/Version|other |All
Platform|Other |All
Target Milestone|Undefined |3.0.4
Version|3.0.3 |SVN Trunk (Latest Devel
| |Version)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From spamassassin@dostech.ca 2005-05-26 22:25 -------
This affects scoring...
rules/50_scores.cf:score RCVD_IN_SORBS_MISC 0 0 0 0.338
rules/50_scores.cf:score RCVD_IN_SORBS_SMTP 0 1.597 0 2.493
rules/50_scores.cf:score RCVD_IN_SORBS_SOCKS 0 1.847 0 2.054
SMTP now MISC
MISC now SOCKS
SOCKS now SMTP
...do we know if the scores are really for how things are now or how they should be?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From felicity@kluge.net 2005-05-27 10:43 -------
I'd imagine that the scores are accurate for the rule names.
(In reply to comment #2)
> This affects scoring...
>
> rules/50_scores.cf:score RCVD_IN_SORBS_MISC 0 0 0 0.338
> rules/50_scores.cf:score RCVD_IN_SORBS_SMTP 0 1.597 0 2.493
> rules/50_scores.cf:score RCVD_IN_SORBS_SOCKS 0 1.847 0 2.054
>
> SMTP now MISC
> MISC now SOCKS
> SOCKS now SMTP
>
> ...do we know if the scores are really for how things are now or how they should be?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From Bob@Menschel.net 2005-05-26 20:49 -------
Created an attachment (id=2906)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2906&action=view)
Corrects three SORBS returns
My reading of the web page and our code agrees. This patch should fix the
problem.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From felicity@kluge.net 2005-05-29 16:29 -------
(In reply to comment #1)
> Created an attachment (id=2906)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2906&action=view) [edit]
> Corrects three SORBS returns
>
> My reading of the web page and our code agrees. This patch should fix the
> problem.
The patch also needs to move the scores around.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] [review] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From spamassassin-contrib@msquadrat.de 2005-05-31 09:56 -------
+1 looks fine
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] [review] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From felicity@kluge.net 2005-05-30 15:36 -------
That looks right as far as I can see.
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2906 is|0 |1
obsolete| |
------- Additional Comments From spamassassin@dostech.ca 2005-05-30 13:29 -------
Created an attachment (id=2909)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2909&action=view)
corrected patch
this patch keeps the scores in line with the proper list
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From Bob@Menschel.net 2005-05-27 16:01 -------
> Wouldn't the scores have been set by the perceptron run for 3.0.0? If so, the
scores would be accurate for how the rules functioned at that time.
Agreed, but if this patch changes the rule names (rather than putting the names
back into sync if they got unsynced somewhere/somewhen), then the scores will be
out of sync.
Therefore, since we're not going to rescore rules for 3.0.4, and will rescore
all rules for 3.1.0, should this patch go only into the 3.1.0 system?
> ..do we know if the scores are really for how things are now or how they
should be?
In my archives, RCVD_IN_SORBS_SMTP is 127.0.0.4 for versions 2.60, 2.64, 3.0.0,
3.0.2, and 3.0.3, and 127.0.0.5 in 2.61 and 2.62. It's as if the rule was wrong
in 2.60, fixed in 2.61 and 2.62, then broke again in 3.0 and 2.64. Am I
interpreting that correctly? If so, then the rules were "wrong" in 3.0.0; the
scores as they exist now work with the rules as they exist now, and only the
name is wrong, but if we change the names for 3.0.4 then the scores will
mismatch the perceptron results.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] [review] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|SORBS tests seem to be wrong|[review] SORBS tests seem to
| |be wrong
------- Additional Comments From spamassassin@dostech.ca 2005-05-30 13:29 -------
fixed in trunk r179144
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] [review] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2005-05-31 11:42 -------
fixed in 3.0 r179261
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4367] SORBS tests seem to be wrong
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4367
------- Additional Comments From schulz@adi.com 2005-05-27 13:28 -------
Wouldn't the scores have been set by the perceptron run for 3.0.0? If so, the
scores would be accurate for how the rules functioned at that time. The rule
names would not have matterd. Has SORBS been rearranged since then?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.