[GitHub] parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

[GitBox <gi...@apache.org>]

parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…
URL: https://github.com/apache/drill/pull/1399#discussion_r205893800
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
 ##########
 @@ -238,13 +245,15 @@ public IterOutcome innerNext() {
           // we have to do the special handling
           if (firstBatchForDataSet && popConfig.getKeys().size() == 0 && incoming.getRecordCount() == 0) {
             constructSpecialBatch();
-            // set state to indicate the fact that we have sent a special batch and input is empty
-            specialBatchSent = true;
             firstBatchForDataSet = true; // reset on the next iteration
             // If outcome is NONE then we send the special batch in the first iteration and the NONE
             // outcome in the next iteration. If outcome is EMIT, we can send the special
-            // batch and the EMIT outcome at the same time.
-            return getFinalOutcome();
+            // batch and the EMIT outcome at the same time. (unless the finalOutcome is OK_NEW_SCHEMA)
+            IterOutcome finalOutcome =  getFinalOutcome();
+            if(finalOutcome  == OK_NEW_SCHEMA) {
+              sendEmit = true;
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services