[jira] [Commented] (NUTCH-1993) Nutch does not use backup parsers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546650#comment-16546650 ] 

ASF GitHub Bot commented on NUTCH-1993:
---------------------------------------

sebastian-nagel opened a new pull request #364: NUTCH-1993 Nutch does not use backup parsers
URL: https://github.com/apache/nutch/pull/364
 
 
   - apply patch contributed by Arkadi Kosmynin
   - return last failed parse result (the empty result returned otherwise does not contain the failure reason)
   - improve javadoc
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Nutch does not use backup parsers
> ---------------------------------
>
>                 Key: NUTCH-1993
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1993
>             Project: Nutch
>          Issue Type: Bug
>          Components: parser
>    Affects Versions: 1.13
>            Reporter: Arkadi Kosmynin
>            Assignee: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.15
>
>         Attachments: NUTCH-1193.patch
>
>
> From reading the code it is clear that it is designed to allow using several parsers to parse a document in a sequence, until it is successfully parsed. In practice, this does not work because these lines 
> if (parseResult != null && !parseResult.isEmpty())
>         return parseResult;
> break the loop even if the parsing has failed because parseResult is not empty anyway, it contains a ParseData with ParseStatus.FAILED.
> A fix:
> if ( parseResult.isAnySuccess() ) 
>         return parseResult;
> Where parseResult.isAnySuccess() returns true if any of the parsing attempts were successful.
> This fix is important because it allows use of backup parsers as originally designed and thus increase index completeness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)