You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2018/07/28 11:01:24 UTC
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/2575
[WIP] fixed for ModularPlan exception during update query
update query is failing in spark-2.2 cluster if mv jars are available because catalogs are not empty if datamap are created for other table also and returns true from isValidPlan() inside MVAnalyzerRule.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata mv_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2575
----
commit 043898b523ed26a4de04b18af257223a0a918d6b
Author: rahul <ra...@...>
Date: 2018-07-28T10:55:07Z
fixed for ModularPlan exception during update query
----
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/2575
retest this please
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7599/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6339/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2575
@rahulforallp Please fix the build.
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2575
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6045/
---
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2575#discussion_r205969751
--- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala ---
@@ -80,7 +80,7 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
}
def isValidPlan(plan: LogicalPlan, catalog: SummaryDatasetCatalog): Boolean = {
- !plan.isInstanceOf[Command] && !isDataMapExists(plan, catalog.listAllSchema()) &&
+ !plan.isInstanceOf[Command] && isDataMapExists(plan, catalog.listAllSchema()) &&
--- End diff --
simply i have created a table in spark-2.2 cluster and after load , updating the record it goes to rewrite the plan. even no datamap created on the same table.
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/2575
retest this please
---
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp closed the pull request at:
https://github.com/apache/carbondata/pull/2575
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7584/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7592/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2575
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6062/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/2575
fixed in #2579
---
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2575#discussion_r205946534
--- Diff: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala ---
@@ -80,7 +80,7 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends Rule[LogicalPlan] {
}
def isValidPlan(plan: LogicalPlan, catalog: SummaryDatasetCatalog): Boolean = {
- !plan.isInstanceOf[Command] && !isDataMapExists(plan, catalog.listAllSchema()) &&
+ !plan.isInstanceOf[Command] && isDataMapExists(plan, catalog.listAllSchema()) &&
--- End diff --
This check is wrong. what exactly the problem you are facing? can you add some test case
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7596/
---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2575
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6361/
---