You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adam Heath (JIRA)" <ji...@apache.org> on 2010/04/02 18:58:27 UTC
[jira] Updated: (OFBIZ-3634) ProductPromoWorker PROMO_GWP
hard-codes a required inventory check
[ https://issues.apache.org/jira/browse/OFBIZ-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Heath updated OFBIZ-3634:
------------------------------
Attachment: PROMO_GWP_inventory_check.patch
> ProductPromoWorker PROMO_GWP hard-codes a required inventory check
> ------------------------------------------------------------------
>
> Key: OFBIZ-3634
> URL: https://issues.apache.org/jira/browse/OFBIZ-3634
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Reporter: Adam Heath
> Attachments: PROMO_GWP_inventory_check.patch
>
>
> PROMO_GWP processing always requires the gifted item to have available inventory. There is no way to have that configurable, no way to have the free item get backordered.
> The attached patch removes the inventory check on *real* products, and instead created a new condition, PPIP_PRODUCT_INV, so that *any* promo can pass/fail based on an inventory check.
> I did not commit this patch, because the full fix would need to handle virtual products as well. I don't understand how PROMO_GWP works with virtual products when doing inventory, so I need help with that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (OFBIZ-3634) ProductPromoWorker PROMO_GWP hard-codes a required inventory check
Posted by Scott Gray <sc...@hotwaxmedia.com>.
On 2/04/2010, at 10:59 AM, Adam Heath wrote:
> Adam Heath (JIRA) wrote:
>> [ https://issues.apache.org/jira/browse/OFBIZ-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Adam Heath updated OFBIZ-3634:
>> ------------------------------
>>
>> Attachment: PROMO_GWP_inventory_check.patch
>>
>>> ProductPromoWorker PROMO_GWP hard-codes a required inventory check
>>> ------------------------------------------------------------------
>>>
>>> Key: OFBIZ-3634
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-3634
>>> Project: OFBiz
>>> Issue Type: Bug
>>> Components: order
>>> Reporter: Adam Heath
>>> Attachments: PROMO_GWP_inventory_check.patch
>>>
>>>
>>> PROMO_GWP processing always requires the gifted item to have available inventory. There is no way to have that configurable, no way to have the free item get backordered.
>>> The attached patch removes the inventory check on *real* products, and instead created a new condition, PPIP_PRODUCT_INV, so that *any* promo can pass/fail based on an inventory check.
>>> I did not commit this patch, because the full fix would need to handle virtual products as well. I don't understand how PROMO_GWP works with virtual products when doing inventory, so I need help with that.
>
> Scott, you originally commented when I asked about the PROMO_GWP
> inventory check. Could you look at this for me? I'd really
> appreciate it.
Sure thing Adam, I'll try and take a look over the weekend.
Re: [jira] Updated: (OFBIZ-3634) ProductPromoWorker PROMO_GWP hard-codes
a required inventory check
Posted by Adam Heath <do...@brainfood.com>.
Adam Heath (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/OFBIZ-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Adam Heath updated OFBIZ-3634:
> ------------------------------
>
> Attachment: PROMO_GWP_inventory_check.patch
>
>> ProductPromoWorker PROMO_GWP hard-codes a required inventory check
>> ------------------------------------------------------------------
>>
>> Key: OFBIZ-3634
>> URL: https://issues.apache.org/jira/browse/OFBIZ-3634
>> Project: OFBiz
>> Issue Type: Bug
>> Components: order
>> Reporter: Adam Heath
>> Attachments: PROMO_GWP_inventory_check.patch
>>
>>
>> PROMO_GWP processing always requires the gifted item to have available inventory. There is no way to have that configurable, no way to have the free item get backordered.
>> The attached patch removes the inventory check on *real* products, and instead created a new condition, PPIP_PRODUCT_INV, so that *any* promo can pass/fail based on an inventory check.
>> I did not commit this patch, because the full fix would need to handle virtual products as well. I don't understand how PROMO_GWP works with virtual products when doing inventory, so I need help with that.
Scott, you originally commented when I asked about the PROMO_GWP
inventory check. Could you look at this for me? I'd really
appreciate it.
Plus, anyone else who might like this fix finished.