You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/19 23:07:20 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8089: Modified slice to leverage APIs to specify buffer size and watermark.

SolidWallOfCode commented on a change in pull request #8089:
URL: https://github.com/apache/trafficserver/pull/8089#discussion_r672689620



##########
File path: plugins/experimental/slice/util.cc
##########
@@ -86,7 +86,8 @@ request_block(TSCont contp, Data *const data)
   }
 
   // create virtual connection back into ATS
-  TSVConn const upvc = TSHttpConnectWithPluginId(reinterpret_cast<sockaddr *>(&data->m_client_ip), PLUGIN_NAME, 0);
+  TSVConn const upvc = TSHttpConnectPlugin(reinterpret_cast<sockaddr *>(&data->m_client_ip), PLUGIN_NAME, 0, data->m_buffer_index,

Review comment:
       Why drop the plugin ID? That's quite useful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org