You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 15:03:12 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request #1215: MINIFICPP-1685 reduce CI usage
szaszm opened a new pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215
remove ubuntu 18.04
reduce ubuntu 20.04 clang scope
remove fedora and debian docker builds
https://issues.apache.org/jira/browse/MINIFICPP-1685
MiNiFi C++ uses quite a lot of github actions time for its builds and tests on various platforms. We can reduce the number of platform by relying on results from similar ones, e.g. remove fedora and keep centos only, or reduce ubuntu-clang scope and rely on mac os x clang builds.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1215: MINIFICPP-1685 reduce CI usage
Posted by GitBox <gi...@apache.org>.
szaszm commented on pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#issuecomment-969210157
There was an email thread about the topic a few months ago, and someone submitted statistics, but I can't find them now. MiNiFi C++ was running for about as long as nifi itself was, despite being a much smaller subproject. Here is one thread, but not the stats: https://lists.apache.org/thread/7t55prtzcmk10pho8xfdjhbvhvkg48vv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1215: MINIFICPP-1685 reduce CI usage
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adam-markovics commented on a change in pull request #1215: MINIFICPP-1685 reduce CI usage
Posted by GitBox <gi...@apache.org>.
adam-markovics commented on a change in pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#discussion_r749414107
##########
File path: .github/workflows/ci.yml
##########
@@ -151,31 +151,10 @@ jobs:
cd build
export CC=clang
export CXX=clang++
- cmake -DUSE_SHARED_LIBS= -DCMAKE_BUILD_TYPE=Release -DENABLE_NANOFI=ON -DENABLE_JNI=ON -DENABLE_SENSORS=ON -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON -DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_COAP=ON -DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON ..
+ cmake -DUSE_SHARED_LIBS= -DCMAKE_BUILD_TYPE=Release -DENABLE_MQTT=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON -DFAIL_ON_WARNINGS=ON ..
cmake --build . --parallel $(nproc)
- name: test
run: cd build && make test ARGS="--timeout 300 -j8 --output-on-failure"
- debian:
Review comment:
Why is Debian dropped? Because Ubuntu pretty much covers it? And what version of Debian was this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1215: MINIFICPP-1685 reduce CI usage
Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#discussion_r749594447
##########
File path: .github/workflows/ci.yml
##########
@@ -151,31 +151,10 @@ jobs:
cd build
export CC=clang
export CXX=clang++
- cmake -DUSE_SHARED_LIBS= -DCMAKE_BUILD_TYPE=Release -DENABLE_NANOFI=ON -DENABLE_JNI=ON -DENABLE_SENSORS=ON -DENABLE_OPENWSMAN=ON -DENABLE_OPENCV=ON -DENABLE_MQTT=ON -DENABLE_GPS=ON -DENABLE_USB_CAMERA=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_OPC=ON -DENABLE_SFTP=ON -DENABLE_COAP=ON -DENABLE_PYTHON=ON -DENABLE_SQL=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON -DSTRICT_GSL_CHECKS=AUDIT -DFAIL_ON_WARNINGS=ON ..
+ cmake -DUSE_SHARED_LIBS= -DCMAKE_BUILD_TYPE=Release -DENABLE_MQTT=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_AWS=ON -DENABLE_AZURE=ON -DFAIL_ON_WARNINGS=ON ..
cmake --build . --parallel $(nproc)
- name: test
run: cd build && make test ARGS="--timeout 300 -j8 --output-on-failure"
- debian:
Review comment:
Yes, there shouldn't be too much of a difference between the jobs. This was buster, and it's becoming obsolete anyway. Bullseye is using gcc 10, which is already mostly covered by centos through devtoolset-10.
It's possible to do much more complete docker builds locally on all supported systems btw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1215: MINIFICPP-1685 reduce CI usage
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on pull request #1215:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1215#issuecomment-969020095
I welcome this change, although it would be nice to quantify how much is "quite a lot" or more importantly what is our target/limit CI time, obviously the less we use the better, but is there a statistics available somewhere we could rely on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org