You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/15 12:54:00 UTC
[jira] [Commented] (KNOX-1816) Execute shellcheck on our Linux
scripts
[ https://issues.apache.org/jira/browse/KNOX-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885198#comment-16885198 ]
ASF subversion and git services commented on KNOX-1816:
-------------------------------------------------------
Commit a1d86ae0351954d553d1795f4da7313ebea7e46a in knox's branch refs/heads/master from Sandor Molnar
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=a1d86ae ]
KNOX-1816 - Added shellcheck validation to our build optionally and fixed issues shellcheck already found (#114)
> Execute shellcheck on our Linux scripts
> ---------------------------------------
>
> Key: KNOX-1816
> URL: https://issues.apache.org/jira/browse/KNOX-1816
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxCLI, KnoxShell, Server
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> It's strongly recommended to execute {{shellcheck}} on the following Linux scripts:
> * {{gateway-release/home/bin/gateway.sh}}
> * {{gateway-release/home/bin/knoxcli.sh}}
> * {{gateway-release/home/bin/ldap.sh}}
> * {{gateway-shell-release/home/bin/knoxshell.sh}}
> It can be done online ([https://www.shellcheck.net/]) or locally after installing the software. Once the check has been executed we should apply the changes the tool recommends to avoid common bash pitfalls.
> Optionally: we may integrate it with our Travis CI build (needs investigation)
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)