You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2024/02/20 10:21:32 UTC

[PR] chore: Bump to version 0.3.0 [iceberg-rust]

Fokko opened a new pull request, #212:
URL: https://github.com/apache/iceberg-rust/pull/212

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954146668

   > The difference lies in how we determine the version to release.
   > 
   > Previously, we would decide on the version just before releasing it. This involved starting a discussion on the mailing list and then bumping up the version accordingly. However, now we must bump the version immediately without prior knowledge of what changes this release will include. For instance, should we release `0.3.0` even if there haven't been any breaking changes?
   
   I think in semver's semantics, upgrading different part has different meanings:
   
   1. Upgrading major version means breaking change. For example, we can upgrade it to 1 when we have finished feature parity with java api, and upgrade it when we have breaking changes.
   2. Upgrading minor version means add new features without breaking change, e.g. `0.2.0` -> `0.3.0`. Since we are currently adding features in main branch, so I think it's fine to upgrade minor version in main branch.
   3. Upgrading patch version means adding bug fix without new feature, e.g. `0.2.0` -> `0.2.1`. In this case, we should create a 0.2.x branch for tags/0.2.0, and adding both bug fix pr to both main branch and 0.2.x, and create tags from 0.2.x branch for patch version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954046224

   > LGTM, I think it's fine to upgrade it now.
   
   Ok, so we will always bump to next version during release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954283514

   > Upgrading minor version means add new features without breaking change, e.g. 0.2.0 -> 0.3.0.
   
   This is a breaking change in semver definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1956510889

   cc @Xuanwo Any other concerns?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1956531739

   > cc @Xuanwo Any other concerns?
   
   I'm ok with this PR content but not its timing.
   
   As I mentioned before, we can decide the version to release in the discussion and bump version in a separate PR to initiate the release process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954392303

   What we do at Python/Java, is create a branch for each major/minor version. If there are any bugs then we can backport them to the branch, and do a quick release. This way you don't have to keep track if you merge any new functionality to the main branch (because patch releases should only contain fixes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed pull request #212: chore: Bump to version 0.3.0
URL: https://github.com/apache/iceberg-rust/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1955956400

   > > Upgrading minor version means add new features without breaking change, e.g. 0.2.0 -> 0.3.0.
   > 
   > This is a breaking change in semver definition.
   
   I took a look at [semver doc](https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility) and you are right. `0.2.0 -> 0.3.0` is considered not compatible, while `1.2.0 -> 1.3.0` is considered compatible. This makes sense since versions starts with `0.` are considered not stable enough.
   
   But I still prefer to upgrade minor version for each release, since it's weird to me to add a lot of features and only upgrade patch version.  🤪
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1978207118

   I'll close this for now. In Java/Python world it is typical to bump the version after the release. Maybe we should create consensus on bumping versions first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1953904667

   Should we bump the version just after releasing or before?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1958476078

   > As I mentioned before, we can decide the version to release in the discussion and bump version in a separate PR to initiate the release process.
   
   Sounds reasonable to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954551404

   Most rust packages just keep moving on next version and don't do backport and cherrypick. And considering our current state, it's less likely for us to maintaining a v0.2 branch 🫣


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1955958747

   > What we do at Python/Java, is create a branch for each major/minor version. If there are any bugs then we can backport them to the branch, and do a quick release. This way you don't have to keep track if you merge any new functionality to the main branch (because patch releases should only contain fixes).
   
   +1, we could do this when this library gets mature enough, we don't need this since it's in a relative early stage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Bump to version 0.3.0 [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #212:
URL: https://github.com/apache/iceberg-rust/pull/212#issuecomment-1954049870

   The difference lies in how we determine the version to release.
   
   Previously, we would decide on the version just before releasing it. This involved starting a discussion on the mailing list and then bumping up the version accordingly. However, now we must bump the version immediately without prior knowledge of what changes this release will include. For instance, should we release `0.3.0` even if there haven't been any breaking changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org